Re: [Qemu-devel] [PATCH 03/10] guest agent: guest-file-open: refactoring

2015-02-19 Thread Denis V. Lunev
On 17/02/15 20:59, Eric Blake wrote: On 02/17/2015 10:56 AM, Michael Roth wrote: In any case, since I was actually the one who re-invented it, and this code just moves it to another function, I think we can address it as a seperate patch and leave the PULL intact (unless there are other objectio

[Qemu-devel] [PATCH 03/10] guest agent: guest-file-open: refactoring

2015-02-17 Thread Michael Roth
From: Simon Zolin Moved the code that sets non-blocking flag on fd into a separate function. Signed-off-by: Simon Zolin Reviewed-by: Roman Kagan Signed-off-by: Denis V. Lunev CC: Michael Roth CC: Eric Blake Signed-off-by: Michael Roth --- qga/commands-posix.c | 31 +++-

Re: [Qemu-devel] [PATCH 03/10] guest agent: guest-file-open: refactoring

2015-02-17 Thread Denis V. Lunev
On 17/02/15 20:56, Michael Roth wrote: Quoting Denis V. Lunev (2015-02-17 10:06:49) On 17/02/15 18:27, Eric Blake wrote: On 02/16/2015 08:14 PM, Michael Roth wrote: From: Simon Zolin Moved the code that sets non-blocking flag on fd into a separate function. Signed-off-by: Simon Zolin Revie

Re: [Qemu-devel] [PATCH 03/10] guest agent: guest-file-open: refactoring

2015-02-17 Thread Eric Blake
On 02/17/2015 10:56 AM, Michael Roth wrote: > In any case, since I was actually the one who re-invented it, > and this code just moves it to another function, I think we > can address it as a seperate patch and leave the PULL > intact (unless there are other objections). Agree that a separate clea

Re: [Qemu-devel] [PATCH 03/10] guest agent: guest-file-open: refactoring

2015-02-17 Thread Michael Roth
Quoting Denis V. Lunev (2015-02-17 10:06:49) > On 17/02/15 18:27, Eric Blake wrote: > > On 02/16/2015 08:14 PM, Michael Roth wrote: > >> From: Simon Zolin > >> > >> Moved the code that sets non-blocking flag on fd into a separate function. > >> > >> Signed-off-by: Simon Zolin > >> Reviewed-by: Ro

Re: [Qemu-devel] [PATCH 03/10] guest agent: guest-file-open: refactoring

2015-02-17 Thread Denis V. Lunev
On 17/02/15 18:27, Eric Blake wrote: On 02/16/2015 08:14 PM, Michael Roth wrote: From: Simon Zolin Moved the code that sets non-blocking flag on fd into a separate function. Signed-off-by: Simon Zolin Reviewed-by: Roman Kagan Signed-off-by: Denis V. Lunev CC: Michael Roth CC: Eric Blake

Re: [Qemu-devel] [PATCH 03/10] guest agent: guest-file-open: refactoring

2015-02-17 Thread Eric Blake
On 02/16/2015 08:14 PM, Michael Roth wrote: > From: Simon Zolin > > Moved the code that sets non-blocking flag on fd into a separate function. > > Signed-off-by: Simon Zolin > Reviewed-by: Roman Kagan > Signed-off-by: Denis V. Lunev > CC: Michael Roth > CC: Eric Blake > Signed-off-by: Micha

[Qemu-devel] [PATCH 03/10] guest agent: guest-file-open: refactoring

2015-02-16 Thread Michael Roth
From: Simon Zolin Moved the code that sets non-blocking flag on fd into a separate function. Signed-off-by: Simon Zolin Reviewed-by: Roman Kagan Signed-off-by: Denis V. Lunev CC: Michael Roth CC: Eric Blake Signed-off-by: Michael Roth --- qga/commands-posix.c | 31 +++-