Re: [Qemu-devel] [PATCH 02/21] qcow2: Add refcount_width to format-specific info

2014-11-11 Thread Eric Blake
On 11/11/2014 01:11 AM, Max Reitz wrote: >>> +.compat = g_strdup("0.10"), >>> +.refcount_width = s->refcount_bits, >> Hmm - is it really worth displaying a constant? Since the 0.10 format >> cannot change the width from 16, I'm not sure if it adds anything t

Re: [Qemu-devel] [PATCH 02/21] qcow2: Add refcount_width to format-specific info

2014-11-11 Thread Max Reitz
On 2014-11-10 at 20:06, Eric Blake wrote: On 11/10/2014 06:45 AM, Max Reitz wrote: Add the bit width of every refcount entry to the format-specific information. This breaks some test outputs, fix them. Signed-off-by: Max Reitz --- block/qcow2.c | 4 +++- qapi/block-core.json

Re: [Qemu-devel] [PATCH 02/21] qcow2: Add refcount_width to format-specific info

2014-11-10 Thread Eric Blake
On 11/10/2014 06:45 AM, Max Reitz wrote: > Add the bit width of every refcount entry to the format-specific > information. > > This breaks some test outputs, fix them. > > Signed-off-by: Max Reitz > --- > block/qcow2.c | 4 +++- > qapi/block-core.json | 5 - > tests/qem

[Qemu-devel] [PATCH 02/21] qcow2: Add refcount_width to format-specific info

2014-11-10 Thread Max Reitz
Add the bit width of every refcount entry to the format-specific information. This breaks some test outputs, fix them. Signed-off-by: Max Reitz --- block/qcow2.c | 4 +++- qapi/block-core.json | 5 - tests/qemu-iotests/060.out | 1 + tests/qemu-iotests/065 | 23 +++