Re: [Qemu-devel] [PATCH 02/18] target-ppc: Add ISA2.06 bpermd Instruction

2013-12-10 Thread Tom Musta
On 12/9/2013 6:01 PM, Richard Henderson wrote: > On 12/09/2013 07:46 AM, Tom Musta wrote: >> +for (i = 0; i < 8; i++) { >> +int index = (rs & (0xFFul) << (i*8)) >> (i*8); > > This is a silly expression. Better as > > int index = (rs >> (i * 8)) & 0xff; > >> +ra |

Re: [Qemu-devel] [PATCH 02/18] target-ppc: Add ISA2.06 bpermd Instruction

2013-12-09 Thread Richard Henderson
On 12/09/2013 07:46 AM, Tom Musta wrote: > +for (i = 0; i < 8; i++) { > +int index = (rs & (0xFFul) << (i*8)) >> (i*8); This is a silly expression. Better as int index = (rs >> (i * 8)) & 0xff; > +ra |= (1<

[Qemu-devel] [PATCH 02/18] target-ppc: Add ISA2.06 bpermd Instruction

2013-12-09 Thread Tom Musta
This patch adds the Bit Permute Doubleword (bpermd) instruction, which was introduced in Power ISA 2.06 as part of the base 64-bit architecture. Signed-off-by: Tom Musta --- target-ppc/helper.h |1 + target-ppc/int_helper.c | 20 target-ppc/translate.c | 10