Re: [Qemu-devel] [PATCH 02/17] imx_fec: Do not calculate FEC

2017-10-09 Thread Peter Maydell
On 9 October 2017 at 15:47, Andrey Smirnov wrote: > On Fri, Oct 6, 2017 at 6:48 AM, Peter Maydell > wrote: >> This looks a bit odd. Doesn't the hardware calculate the CRC here? >> > > It does, it just seemed to me that since the hardware also has a "CRC > error" bit in its status register, there

Re: [Qemu-devel] [PATCH 02/17] imx_fec: Do not calculate FEC

2017-10-09 Thread Andrey Smirnov
On Fri, Oct 6, 2017 at 6:48 AM, Peter Maydell wrote: > On 18 September 2017 at 20:50, Andrey Smirnov > wrote: >> Save some computation time and avoid calculating CRC's frame >> >> Cc: Peter Maydell >> Cc: Jason Wang >> Cc: qemu-devel@nongnu.org >> Cc: qemu-...@nongnu.org >> Cc: yurov...@gmail.

Re: [Qemu-devel] [PATCH 02/17] imx_fec: Do not calculate FEC

2017-10-06 Thread Peter Maydell
On 18 September 2017 at 20:50, Andrey Smirnov wrote: > Save some computation time and avoid calculating CRC's frame > > Cc: Peter Maydell > Cc: Jason Wang > Cc: qemu-devel@nongnu.org > Cc: qemu-...@nongnu.org > Cc: yurov...@gmail.com > Signed-off-by: Andrey Smirnov > --- > hw/net/imx_fec.c | 9

[Qemu-devel] [PATCH 02/17] imx_fec: Do not calculate FEC

2017-09-18 Thread Andrey Smirnov
Save some computation time and avoid calculating CRC's frame Cc: Peter Maydell Cc: Jason Wang Cc: qemu-devel@nongnu.org Cc: qemu-...@nongnu.org Cc: yurov...@gmail.com Signed-off-by: Andrey Smirnov --- hw/net/imx_fec.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a