Re: [Qemu-devel] [PATCH 02/15] sheepdog: Fix error handling in sd_snapshot_delete()

2017-03-03 Thread Markus Armbruster
Kevin Wolf writes: > Am 02.03.2017 um 22:43 hat Markus Armbruster geschrieben: >> As a bdrv_snapshot_delete() method, sd_snapshot_delete() must set an >> error and return negative errno on failure. It sometimes returns -1, >> and sometimes neglects to set an error. It also prints error messages

Re: [Qemu-devel] [PATCH 02/15] sheepdog: Fix error handling in sd_snapshot_delete()

2017-03-03 Thread Kevin Wolf
Am 02.03.2017 um 22:43 hat Markus Armbruster geschrieben: > As a bdrv_snapshot_delete() method, sd_snapshot_delete() must set an > error and return negative errno on failure. It sometimes returns -1, > and sometimes neglects to set an error. It also prints error messages > with error_report(). F

Re: [Qemu-devel] [PATCH 02/15] sheepdog: Fix error handling in sd_snapshot_delete()

2017-03-02 Thread Markus Armbruster
Eric Blake writes: > On 03/02/2017 03:43 PM, Markus Armbruster wrote: >> As a bdrv_snapshot_delete() method, sd_snapshot_delete() must set an >> error and return negative errno on failure. It sometimes returns -1, >> and sometimes neglects to set an error. It also prints error messages >> with

Re: [Qemu-devel] [PATCH 02/15] sheepdog: Fix error handling in sd_snapshot_delete()

2017-03-02 Thread Eric Blake
On 03/02/2017 03:43 PM, Markus Armbruster wrote: > As a bdrv_snapshot_delete() method, sd_snapshot_delete() must set an > error and return negative errno on failure. It sometimes returns -1, > and sometimes neglects to set an error. It also prints error messages > with error_report(). Fix all th

[Qemu-devel] [PATCH 02/15] sheepdog: Fix error handling in sd_snapshot_delete()

2017-03-02 Thread Markus Armbruster
As a bdrv_snapshot_delete() method, sd_snapshot_delete() must set an error and return negative errno on failure. It sometimes returns -1, and sometimes neglects to set an error. It also prints error messages with error_report(). Fix all that. Moreover, its handling of an attempt to delete an no