Il 04/05/2012 18:51, Stefan Weil ha scritto:
> The tabs in patches 6 and 7 are more problematic.
> Although they are not at the start of the line, tabs
> should be completely avoided (that's my personal
> understanding of QEMU's coding rules).
ok, I pushed an updated patchset to scsi-next (commit
Am 04.05.2012 18:29, schrieb Paolo Bonzini:
Il 04/05/2012 18:28, Stefan Weil ha scritto:
- !(buf[0] == REQUEST_SENSE&& d->sense_is_ua))) { + if (cmd.xfer>
INT32_MAX) { + req = scsi_req_alloc(&reqops_invalid_field, d, tag,
lun, hba_private);
WARNING: line over 80 characters #54: FILE: hw/scsi-b
Il 04/05/2012 18:28, Stefan Weil ha scritto:
>>
>> - !(buf[0] == REQUEST_SENSE&& d->sense_is_ua))) {
>> +if (cmd.xfer> INT32_MAX) {
>> +req = scsi_req_alloc(&reqops_invalid_field, d, tag, lun,
>> hba_private);
>
> WARNING: line over 80 characters
> #54: FILE: hw/s
Am 04.05.2012 10:45, schrieb Paolo Bonzini:
Avoid sending more than 2GB of data, as that can cause overflows
in int32_t variables.
Signed-off-by: Paolo Bonzini
---
hw/scsi-bus.c | 38 ++
1 file changed, 26 insertions(+), 12 deletions(-)
diff --git a/hw/s
Avoid sending more than 2GB of data, as that can cause overflows
in int32_t variables.
Signed-off-by: Paolo Bonzini
---
hw/scsi-bus.c | 38 ++
1 file changed, 26 insertions(+), 12 deletions(-)
diff --git a/hw/scsi-bus.c b/hw/scsi-bus.c
index dbdb99c..c29a4a
