Re: [Qemu-devel] [PATCH 02/14] check-qdict: Simplify qdict_crumple_test_recursive()

2017-02-18 Thread Markus Armbruster
Eric Blake writes: > On 02/17/2017 02:38 PM, Markus Armbruster wrote: >> Use qdict_get_qdict(), qdict_get_qlist() instead of qdict_get() >> followed by qobject_to_qdict(), qobject_to_qlist(). > > Worth a Coccinelle script to make sure we catch it all? I'm pretty sure I got them all: I examined a

Re: [Qemu-devel] [PATCH 02/14] check-qdict: Simplify qdict_crumple_test_recursive()

2017-02-17 Thread Eric Blake
On 02/17/2017 02:38 PM, Markus Armbruster wrote: > Use qdict_get_qdict(), qdict_get_qlist() instead of qdict_get() > followed by qobject_to_qdict(), qobject_to_qlist(). Worth a Coccinelle script to make sure we catch it all? > > While there, drop some redundant code. > > Signed-off-by: Markus A

[Qemu-devel] [PATCH 02/14] check-qdict: Simplify qdict_crumple_test_recursive()

2017-02-17 Thread Markus Armbruster
Use qdict_get_qdict(), qdict_get_qlist() instead of qdict_get() followed by qobject_to_qdict(), qobject_to_qlist(). While there, drop some redundant code. Signed-off-by: Markus Armbruster --- tests/check-qdict.c | 25 + 1 file changed, 9 insertions(+), 16 deletions(-) d