Re: [Qemu-devel] [PATCH 02/13] Implement cpu_physical_memory_set()

2012-06-21 Thread Benjamin Herrenschmidt
On Wed, 2012-06-20 at 16:15 -0500, Anthony Liguori wrote: > On 06/19/2012 01:39 AM, Benjamin Herrenschmidt wrote: > > From: David Gibson > > > > This patch adds cpu_physical_memory_set() function. This is equivalent to > > calling cpu_physical_memory_write() with a buffer filled with a character,

Re: [Qemu-devel] [PATCH 02/13] Implement cpu_physical_memory_set()

2012-06-20 Thread Benjamin Herrenschmidt
On Thu, 2012-06-21 at 11:45 +1000, David Gibson wrote: > > Why should this be in the core API? Shouldn't this be a helper on > > top of the DMA API? > > Well, I was hoping to avoid having to allocate a temporary buffer of > zeroes, which is necessary to do this in terms of the existing > cpu_phys

Re: [Qemu-devel] [PATCH 02/13] Implement cpu_physical_memory_set()

2012-06-20 Thread David Gibson
On Wed, Jun 20, 2012 at 04:15:13PM -0500, Anthony Liguori wrote: > On 06/19/2012 01:39 AM, Benjamin Herrenschmidt wrote: > >From: David Gibson > > > >This patch adds cpu_physical_memory_set() function. This is equivalent to > >calling cpu_physical_memory_write() with a buffer filled with a charact

Re: [Qemu-devel] [PATCH 02/13] Implement cpu_physical_memory_set()

2012-06-20 Thread David Gibson
On Thu, Jun 21, 2012 at 11:45:14AM +1000, David Gibson wrote: > On Wed, Jun 20, 2012 at 04:15:13PM -0500, Anthony Liguori wrote: > > On 06/19/2012 01:39 AM, Benjamin Herrenschmidt wrote: > > >From: David Gibson > > > > > >This patch adds cpu_physical_memory_set() function. This is equivalent to >

Re: [Qemu-devel] [PATCH 02/13] Implement cpu_physical_memory_set()

2012-06-20 Thread Anthony Liguori
On 06/20/2012 04:30 PM, Benjamin Herrenschmidt wrote: On Wed, 2012-06-20 at 16:15 -0500, Anthony Liguori wrote: On 06/19/2012 01:39 AM, Benjamin Herrenschmidt wrote: From: David Gibson This patch adds cpu_physical_memory_set() function. This is equivalent to calling cpu_physical_memory_write(

Re: [Qemu-devel] [PATCH 02/13] Implement cpu_physical_memory_set()

2012-06-20 Thread Benjamin Herrenschmidt
On Wed, 2012-06-20 at 16:15 -0500, Anthony Liguori wrote: > On 06/19/2012 01:39 AM, Benjamin Herrenschmidt wrote: > > From: David Gibson > > > > This patch adds cpu_physical_memory_set() function. This is equivalent to > > calling cpu_physical_memory_write() with a buffer filled with a character,

Re: [Qemu-devel] [PATCH 02/13] Implement cpu_physical_memory_set()

2012-06-20 Thread Anthony Liguori
On 06/19/2012 01:39 AM, Benjamin Herrenschmidt wrote: From: David Gibson This patch adds cpu_physical_memory_set() function. This is equivalent to calling cpu_physical_memory_write() with a buffer filled with a character, ie, a memset of target memory. It uses a small temporary buffer on the s

[Qemu-devel] [PATCH 02/13] Implement cpu_physical_memory_set()

2012-06-19 Thread Benjamin Herrenschmidt
From: David Gibson This patch adds cpu_physical_memory_set() function. This is equivalent to calling cpu_physical_memory_write() with a buffer filled with a character, ie, a memset of target memory. It uses a small temporary buffer on the stack. Signed-off-by: David Gibson Signed-off-by: Benj