Re: [Qemu-devel] [PATCH 02/12] migration: fix counting normal page for compression

2018-06-13 Thread Xiao Guangrong
On 06/13/2018 11:51 PM, Dr. David Alan Gilbert wrote: * guangrong.x...@gmail.com (guangrong.x...@gmail.com) wrote: From: Xiao Guangrong The compressed page is not normal page Is this the right reason? I think the 'normal' page shouldn't include the compressed page and XBZRLE-ed page (th

Re: [Qemu-devel] [PATCH 02/12] migration: fix counting normal page for compression

2018-06-13 Thread Dr. David Alan Gilbert
* guangrong.x...@gmail.com (guangrong.x...@gmail.com) wrote: > From: Xiao Guangrong > > The compressed page is not normal page Is this the right reason? I think we always increment some counter for a page - so what gets incremented for a compressed page? Is the real answer that we do: ram_sav

[Qemu-devel] [PATCH 02/12] migration: fix counting normal page for compression

2018-06-04 Thread guangrong . xiao
From: Xiao Guangrong The compressed page is not normal page Signed-off-by: Xiao Guangrong --- migration/ram.c | 1 - 1 file changed, 1 deletion(-) diff --git a/migration/ram.c b/migration/ram.c index 0caf32ab0a..dbf24d8c87 100644 --- a/migration/ram.c +++ b/migration/ram.c @@ -1432,7 +1432,6