Re: [Qemu-devel] [PATCH 02/11] migration: qemu_savevm_state_cleanup() in cleanup

On Wed, Jan 03, 2018 at 12:18:54PM +0100, Juan Quintela wrote: > Peter Xu wrote: > > On Wed, Jan 03, 2018 at 11:21:31AM +0100, Juan Quintela wrote: > >> Peter Xu wrote: > >> > On Wed, Jan 03, 2018 at 10:15:41AM +0100, Juan Quintela wrote: > >> >> Peter Xu wrote: > >> >> > Moving existing callers

Re: [Qemu-devel] [PATCH 02/11] migration: qemu_savevm_state_cleanup() in cleanup

Peter Xu wrote: > On Wed, Jan 03, 2018 at 11:21:31AM +0100, Juan Quintela wrote: >> Peter Xu wrote: >> > On Wed, Jan 03, 2018 at 10:15:41AM +0100, Juan Quintela wrote: >> >> Peter Xu wrote: >> >> > Moving existing callers all into migrate_fd_cleanup(). It simplifies >> >> > migration_thread() a

Re: [Qemu-devel] [PATCH 02/11] migration: qemu_savevm_state_cleanup() in cleanup

On Wed, Jan 03, 2018 at 11:21:31AM +0100, Juan Quintela wrote: > Peter Xu wrote: > > On Wed, Jan 03, 2018 at 10:15:41AM +0100, Juan Quintela wrote: > >> Peter Xu wrote: > >> > Moving existing callers all into migrate_fd_cleanup(). It simplifies > >> > migration_thread() a bit. > >> > > >> > Sign

Re: [Qemu-devel] [PATCH 02/11] migration: qemu_savevm_state_cleanup() in cleanup

Peter Xu wrote: > On Wed, Jan 03, 2018 at 10:15:41AM +0100, Juan Quintela wrote: >> Peter Xu wrote: >> > Moving existing callers all into migrate_fd_cleanup(). It simplifies >> > migration_thread() a bit. >> > >> > Signed-off-by: Peter Xu >> >> Reviewed-by: Juan Quintela > > Thanks. > >> >>

Re: [Qemu-devel] [PATCH 02/11] migration: qemu_savevm_state_cleanup() in cleanup

On Wed, Jan 03, 2018 at 10:15:41AM +0100, Juan Quintela wrote: > Peter Xu wrote: > > Moving existing callers all into migrate_fd_cleanup(). It simplifies > > migration_thread() a bit. > > > > Signed-off-by: Peter Xu > > Reviewed-by: Juan Quintela Thanks. > > I am trying to see if we can cal

Re: [Qemu-devel] [PATCH 02/11] migration: qemu_savevm_state_cleanup() in cleanup

Peter Xu wrote: > Moving existing callers all into migrate_fd_cleanup(). It simplifies > migration_thread() a bit. > > Signed-off-by: Peter Xu Reviewed-by: Juan Quintela I am trying to see if we can call migrate_fd_cleanup() twice. As far as I can see, we are not doing it. But, and it is a

[Qemu-devel] [PATCH 02/11] migration: qemu_savevm_state_cleanup() in cleanup

Moving existing callers all into migrate_fd_cleanup(). It simplifies migration_thread() a bit. Signed-off-by: Peter Xu --- migration/migration.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/migration/migration.c b/migration/migration.c index 0ee4b4c27c..edbda43