Re: [Qemu-devel] [PATCH 02/10] block/dmg: extract mish block decoding functionality

2015-01-06 Thread Stefan Hajnoczi
On Sat, Dec 27, 2014 at 04:01:36PM +0100, Peter Wu wrote: > Extract the mish block decoder such that this can be used for other > formats in the future. A new DmgHeaderState struct is introduced to > share state while decoding. > > The code is kept unchanged as much as possible, a "fail" label is

Re: [Qemu-devel] [PATCH 02/10] block/dmg: extract mish block decoding functionality

2015-01-03 Thread Peter Wu
On Friday 02 January 2015 18:59:38 John Snow wrote: > > On 12/27/2014 10:01 AM, Peter Wu wrote: > > Extract the mish block decoder such that this can be used for other > > formats in the future. A new DmgHeaderState struct is introduced to > > share state while decoding. > > > > The code is kept u

Re: [Qemu-devel] [PATCH 02/10] block/dmg: extract mish block decoding functionality

2015-01-02 Thread John Snow
On 12/27/2014 10:01 AM, Peter Wu wrote: Extract the mish block decoder such that this can be used for other formats in the future. A new DmgHeaderState struct is introduced to share state while decoding. The code is kept unchanged as much as possible, a "fail" label is added for example where

[Qemu-devel] [PATCH 02/10] block/dmg: extract mish block decoding functionality

2014-12-27 Thread Peter Wu
Extract the mish block decoder such that this can be used for other formats in the future. A new DmgHeaderState struct is introduced to share state while decoding. The code is kept unchanged as much as possible, a "fail" label is added for example where a simple return would probably do. Signed-o