[Qemu-devel] [PATCH 01/32] fdc: Drop broken code for user-defined floppy geometry

2012-07-06 Thread Markus Armbruster
bdrv_get_floppy_geometry_hint() fails to store through its parameter drive when bs has a geometry hint. Makes fd_revalidate() assign random crap to drv->drive. Has been broken that way for ages. Harmless, because: * The only way to set a geometry hint is -drive if=none,cyls=... Since commit c

[Qemu-devel] [PATCH 01/32] fdc: Drop broken code for user-defined floppy geometry

2012-06-29 Thread Markus Armbruster
bdrv_get_floppy_geometry_hint() fails to store through its parameter drive when bs has a geometry hint. Makes fd_revalidate() assign random crap to drv->drive. Has been broken that way for ages. Harmless, because: * The only way to set a geometry hint is -drive if=none,cyls=... Since commit c