Re: [Qemu-devel] [PATCH 01/23] Hierarchical memory region API

2011-07-26 Thread Avi Kivity
On 07/25/2011 09:41 PM, Anthony Liguori wrote: +/* Initialize a memory region + * + * The region typically acts as a container for other memory regions. + */ I'm also writing a fair bit of documentation right now. We should use a common format and declare that the doc format in CODING_STYLE.

Re: [Qemu-devel] [PATCH 01/23] Hierarchical memory region API

2011-07-25 Thread Anthony Liguori
On 07/25/2011 09:02 AM, Avi Kivity wrote: The memory API separates the attributes of a memory region (its size, how reads or writes are handled, dirty logging, and coalescing) from where it is mapped and whether it is enabled. This allows a device to configure a memory region once, then hand it

[Qemu-devel] [PATCH 01/23] Hierarchical memory region API

2011-07-25 Thread Avi Kivity
The memory API separates the attributes of a memory region (its size, how reads or writes are handled, dirty logging, and coalescing) from where it is mapped and whether it is enabled. This allows a device to configure a memory region once, then hand it off to its parent bus to map it according to