Re: [Qemu-devel] [PATCH 01/20] target-mips: add MSA defines and data structure

2014-10-24 Thread Leon Alrae
On 24/10/2014 10:35, Yongbok Kim wrote: > Hi, > > On 22/10/2014 12:35, James Hogan wrote: >> +union wr_t { >> +int8_t b[MSA_WRLEN/8]; >> +int16_t h[MSA_WRLEN/16]; >> +int32_t w[MSA_WRLEN/32]; >> +int64_t d[MSA_WRLEN/64]; >> This is incorrect on a big endian host. The least signifi

Re: [Qemu-devel] [PATCH 01/20] target-mips: add MSA defines and data structure

2014-10-24 Thread Yongbok Kim
Hi, On 22/10/2014 12:35, James Hogan wrote: +union wr_t { +int8_t b[MSA_WRLEN/8]; +int16_t h[MSA_WRLEN/16]; +int32_t w[MSA_WRLEN/32]; +int64_t d[MSA_WRLEN/64]; This is incorrect on a big endian host. The least significant bits of the lowest indexed element should always alias.

Re: [Qemu-devel] [PATCH 01/20] target-mips: add MSA defines and data structure

2014-10-22 Thread James Hogan
Hi, On 14/07/14 10:55, Yongbok Kim wrote: > +typedef struct CPUMIPSMSAContext CPUMIPSMSAContext; > +struct CPUMIPSMSAContext { > +int32_t msair; > +int32_t msacsr; > +int32_t msaaccess; > +int32_t msasave; > +int32_t msamodify; > +int32_t msarequest; > +int32_t msama

Re: [Qemu-devel] [PATCH 01/20] target-mips: add MSA defines and data structure

2014-10-22 Thread James Hogan
Hi, On 14/07/14 10:55, Yongbok Kim wrote: > +union wr_t { > +int8_t b[MSA_WRLEN/8]; > +int16_t h[MSA_WRLEN/16]; > +int32_t w[MSA_WRLEN/32]; > +int64_t d[MSA_WRLEN/64]; This is incorrect on a big endian host. The least significant bits of the lowest indexed element should always a

[Qemu-devel] [PATCH 01/20] target-mips: add MSA defines and data structure

2014-07-14 Thread Yongbok Kim
add defines and data structure for MIPS SIMD Architecture Signed-off-by: Yongbok Kim --- target-mips/cpu.h | 79 +-- target-mips/mips-defs.h |1 + target-mips/op_helper.c |1 + 3 files changed, 78 insertions(+), 3 deletions(-) diff --g