Re: [Qemu-devel] [PATCH 01/15] target-tricore: Add target stubs and qom-cpu

2014-07-11 Thread Peter Maydell
On 11 July 2014 12:05, Bastian Koppelmann wrote: > On 07/07/2014 08:24 PM, Peter Maydell wrote: >> I think you probably want the configure and default-configs changes to be >> at the end of the patch series (or at least part way through it), not at the >> start. The general approach is: * some pat

Re: [Qemu-devel] [PATCH 01/15] target-tricore: Add target stubs and qom-cpu

2014-07-11 Thread Bastian Koppelmann
Hi Peter, On 07/07/2014 08:24 PM, Peter Maydell wrote: I think you probably want the configure and default-configs changes to be at the end of the patch series (or at least part way through it), not at the start. The general approach is: * some patches which implement the basic absolute minimu

Re: [Qemu-devel] [PATCH 01/15] target-tricore: Add target stubs and qom-cpu

2014-07-07 Thread Richard Henderson
On 07/07/2014 11:13 AM, Bastian Koppelmann wrote: > QEMU_ARCH_MOXIE = 0x8000, > +QEMU_ARCH_TRICORE = 0x16000, Hexidecimal, not decimal doubling. This file is a mess, I agree. A separate patch to standardize the existing numbers to hex would be appreciated. r~

Re: [Qemu-devel] [PATCH 01/15] target-tricore: Add target stubs and qom-cpu

2014-07-07 Thread Richard Henderson
On 07/07/2014 11:13 AM, Bastian Koppelmann wrote: > + > +/* GPR Register */ > +target_ulong gpr_a[16]; > +target_ulong gpr_d[16]; > +}; > + > +typedef struct tricore_def_t tricore_def_t; > + > +typedef struct CPUTRICOREState CPUTRICOREState; > +struct CPUTRICOREState { > +TCState ac

Re: [Qemu-devel] [PATCH 01/15] target-tricore: Add target stubs and qom-cpu

2014-07-07 Thread Peter Maydell
On 7 July 2014 19:13, Bastian Koppelmann wrote: > Add TriCore target stubs, QOM cpu and basic machine. > > Signed-off-by: Bastian Koppelmann > --- > arch_init.c | 2 + > configure | 13 ++ > cpu-exec.c | 11 +- > cpus

[Qemu-devel] [PATCH 01/15] target-tricore: Add target stubs and qom-cpu

2014-07-07 Thread Bastian Koppelmann
Add TriCore target stubs, QOM cpu and basic machine. Signed-off-by: Bastian Koppelmann --- arch_init.c | 2 + configure | 13 ++ cpu-exec.c | 11 +- cpus.c | 6 + default-configs/tricore