Re: [Qemu-devel] [PATCH 01/15] pc: merge pc_piix.c into pc.c

2012-01-27 Thread Anthony Liguori
On 01/27/2012 08:15 AM, Jan Kiszka wrote: On 2012-01-27 15:06, Anthony Liguori wrote: On 01/27/2012 07:32 AM, Jan Kiszka wrote: On 2012-01-27 14:07, Anthony Liguori wrote: On 01/27/2012 02:50 AM, Jan Kiszka wrote: On 2012-01-26 20:00, Anthony Liguori wrote: A long time ago, there was a grand

Re: [Qemu-devel] [PATCH 01/15] pc: merge pc_piix.c into pc.c

2012-01-27 Thread Jan Kiszka
On 2012-01-27 15:06, Anthony Liguori wrote: > On 01/27/2012 07:32 AM, Jan Kiszka wrote: >> On 2012-01-27 14:07, Anthony Liguori wrote: >>> On 01/27/2012 02:50 AM, Jan Kiszka wrote: On 2012-01-26 20:00, Anthony Liguori wrote: > A long time ago, there was a grand plan to merge q35 chipset su

Re: [Qemu-devel] [PATCH 01/15] pc: merge pc_piix.c into pc.c

2012-01-27 Thread Anthony Liguori
On 01/27/2012 07:32 AM, Jan Kiszka wrote: On 2012-01-27 14:07, Anthony Liguori wrote: On 01/27/2012 02:50 AM, Jan Kiszka wrote: On 2012-01-26 20:00, Anthony Liguori wrote: A long time ago, there was a grand plan to merge q35 chipset support. The start of that series was a refactoring of pc.c

Re: [Qemu-devel] [PATCH 01/15] pc: merge pc_piix.c into pc.c

2012-01-27 Thread Anthony Liguori
On 01/27/2012 08:03 AM, Andreas Färber wrote: Am 27.01.2012 14:07, schrieb Anthony Liguori: [...] My guess is that a SuperIO chip could be an ISADevice and that we could simply make the PIIX3 has-a SuperIO. Then the ISAPC would have a trivial ISA chipset that has-a SuperIO. That sounds pretty

Re: [Qemu-devel] [PATCH 01/15] pc: merge pc_piix.c into pc.c

2012-01-27 Thread Andreas Färber
Am 27.01.2012 14:07, schrieb Anthony Liguori: > [...] My guess is that a SuperIO > chip could be an ISADevice and that we could simply make the PIIX3 has-a > SuperIO. Then the ISAPC would have a trivial ISA chipset that has-a > SuperIO. That sounds pretty much like our construction site for PReP.

Re: [Qemu-devel] [PATCH 01/15] pc: merge pc_piix.c into pc.c

2012-01-27 Thread Jan Kiszka
On 2012-01-27 14:07, Anthony Liguori wrote: > On 01/27/2012 02:50 AM, Jan Kiszka wrote: >> On 2012-01-26 20:00, Anthony Liguori wrote: >>> A long time ago, there was a grand plan to merge q35 chipset support. The >>> start >>> of that series was a refactoring of pc.c which split a bunch of the "c

Re: [Qemu-devel] [PATCH 01/15] pc: merge pc_piix.c into pc.c

2012-01-27 Thread Anthony Liguori
On 01/27/2012 02:50 AM, Jan Kiszka wrote: On 2012-01-26 20:00, Anthony Liguori wrote: A long time ago, there was a grand plan to merge q35 chipset support. The start of that series was a refactoring of pc.c which split a bunch of the "common" functionality into a separate file that could be sha

Re: [Qemu-devel] [PATCH 01/15] pc: merge pc_piix.c into pc.c

2012-01-27 Thread Jan Kiszka
On 2012-01-26 20:00, Anthony Liguori wrote: > A long time ago, there was a grand plan to merge q35 chipset support. The > start > of that series was a refactoring of pc.c which split a bunch of the "common" > functionality into a separate file that could be shared by the two. > > But q35 never g

[Qemu-devel] [PATCH 01/15] pc: merge pc_piix.c into pc.c

2012-01-26 Thread Anthony Liguori
A long time ago, there was a grand plan to merge q35 chipset support. The start of that series was a refactoring of pc.c which split a bunch of the "common" functionality into a separate file that could be shared by the two. But q35 never got merged and the refactoring, in retrospect, just made t

Re: [Qemu-devel] [PATCH 01/15] pc: merge pc_piix.c into pc.c

2012-01-26 Thread Anthony Liguori
On 01/26/2012 01:00 PM, Anthony Liguori wrote: A long time ago, there was a grand plan to merge q35 chipset support. The start of that series was a refactoring of pc.c which split a bunch of the "common" functionality into a separate file that could be shared by the two. But q35 never got merge