Re: [Qemu-devel] [PATCH 01/13] Better support for dma_addr_t variables

2012-06-21 Thread Benjamin Herrenschmidt
On Wed, 2012-06-20 at 16:14 -0500, Anthony Liguori wrote: > diff --git a/hw/qdev-dma.h b/hw/qdev-dma.h > > new file mode 100644 > > index 000..f0ff558 > > --- /dev/null > > +++ b/hw/qdev-dma.h > > @@ -0,0 +1,12 @@ > > +/* > > + * Support for dma_addr_t typed properties > > + * > > + * Copyrig

Re: [Qemu-devel] [PATCH 01/13] Better support for dma_addr_t variables

2012-06-21 Thread Peter Maydell
On 20 June 2012 23:59, Anthony Liguori wrote: > On 06/20/2012 05:26 PM, Peter Maydell wrote: >> On 20 June 2012 22:14, Anthony Liguori  wrote: >> ...for that matter weren't we tossing around the idea of just >> making target_phys_addr_t 64 bits for everything? (I actually >> want to do this for ta

Re: [Qemu-devel] [PATCH 01/13] Better support for dma_addr_t variables

2012-06-20 Thread David Gibson
On Thu, Jun 21, 2012 at 07:29:23AM +1000, Benjamin Herrenschmidt wrote: > On Wed, 2012-06-20 at 16:14 -0500, Anthony Liguori wrote: > > > Why not make life easy and fix dma_addr_t to 64-bit? > > No opinion on my side, that's from the original patch series, I suppose > the goal was to avoid the ov

Re: [Qemu-devel] [PATCH 01/13] Better support for dma_addr_t variables

2012-06-20 Thread Anthony Liguori
On 06/20/2012 05:26 PM, Peter Maydell wrote: On 20 June 2012 22:14, Anthony Liguori wrote: Why not make life easy and fix dma_addr_t to 64-bit? ...for that matter weren't we tossing around the idea of just making target_phys_addr_t 64 bits for everything? (I actually want to do this for targe

Re: [Qemu-devel] [PATCH 01/13] Better support for dma_addr_t variables

2012-06-20 Thread Peter Maydell
On 20 June 2012 22:14, Anthony Liguori wrote: > Why not make life easy and fix dma_addr_t to 64-bit? ...for that matter weren't we tossing around the idea of just making target_phys_addr_t 64 bits for everything? (I actually want to do this for target-arm anyway; last time I did some quick smoke-

Re: [Qemu-devel] [PATCH 01/13] Better support for dma_addr_t variables

2012-06-20 Thread Benjamin Herrenschmidt
On Wed, 2012-06-20 at 16:14 -0500, Anthony Liguori wrote: > Why not make life easy and fix dma_addr_t to 64-bit? No opinion on my side, that's from the original patch series, I suppose the goal was to avoid the overhead/bloat on 32-bit only platforms/targets. Cheers, Ben.

Re: [Qemu-devel] [PATCH 01/13] Better support for dma_addr_t variables

2012-06-20 Thread Anthony Liguori
On 06/19/2012 01:39 AM, Benjamin Herrenschmidt wrote: From: David Gibson A while back, we introduced the dma_addr_t type, which is supposed to be used for bus visible memory addresses. At present, this is an alias for target_phys_addr_t, but this will change when we eventually add support for g

[Qemu-devel] [PATCH 01/13] Better support for dma_addr_t variables

2012-06-19 Thread Benjamin Herrenschmidt
From: David Gibson A while back, we introduced the dma_addr_t type, which is supposed to be used for bus visible memory addresses. At present, this is an alias for target_phys_addr_t, but this will change when we eventually add support for guest visible IOMMUs. There are some instances of targe

[Qemu-devel] [PATCH 01/13] Better support for dma_addr_t variables

2012-05-09 Thread Benjamin Herrenschmidt
From: David Gibson A while back, we introduced the dma_addr_t type, which is supposed to be used for bus visible memory addresses. At present, this is an alias for target_phys_addr_t, but this will change when we eventually add support for guest visible IOMMUs. There are some instances of targe

[Qemu-devel] [PATCH 01/13] Better support for dma_addr_t variables

2012-04-19 Thread David Gibson
A while back, we introduced the dma_addr_t type, which is supposed to be used for bus visible memory addresses. At present, this is an alias for target_phys_addr_t, but this will change when we eventually add support for guest visible IOMMUs. There are some instances of target_phys_addr_t in the