Re: [Qemu-devel] [PATCH 01/12] tap: multiqueue support

2013-01-10 Thread Jason Wang
On 01/10/2013 06:28 PM, Stefan Hajnoczi wrote: > On Fri, Dec 28, 2012 at 06:31:53PM +0800, Jason Wang wrote: > > Mainly suggestions to make the code easier to understand, but see the > comment about the 1:1 queue/NetClientState model for a general issue > with this approach. Ok, thanks for the rev

Re: [Qemu-devel] [PATCH 01/12] tap: multiqueue support

2013-01-10 Thread Stefan Hajnoczi
On Fri, Dec 28, 2012 at 06:31:53PM +0800, Jason Wang wrote: Mainly suggestions to make the code easier to understand, but see the comment about the 1:1 queue/NetClientState model for a general issue with this approach. > Recently, linux support multiqueue tap which could let userspace call > TUN

Re: [Qemu-devel] [PATCH 01/12] tap: multiqueue support

2013-01-10 Thread Stefan Hajnoczi
On Wed, Jan 09, 2013 at 11:25:24PM +0800, Jason Wang wrote: > On 01/09/2013 05:56 PM, Stefan Hajnoczi wrote: > > On Fri, Dec 28, 2012 at 06:31:53PM +0800, Jason Wang wrote: > >> diff --git a/qapi-schema.json b/qapi-schema.json > >> index 5dfa052..583eb7c 100644 > >> --- a/qapi-schema.json > >> +++

Re: [Qemu-devel] [PATCH 01/12] tap: multiqueue support

2013-01-09 Thread Jason Wang
On 01/09/2013 05:56 PM, Stefan Hajnoczi wrote: > On Fri, Dec 28, 2012 at 06:31:53PM +0800, Jason Wang wrote: >> diff --git a/qapi-schema.json b/qapi-schema.json >> index 5dfa052..583eb7c 100644 >> --- a/qapi-schema.json >> +++ b/qapi-schema.json >> @@ -2465,7 +2465,7 @@ >> { 'type': 'NetdevTapOpti

Re: [Qemu-devel] [PATCH 01/12] tap: multiqueue support

2013-01-09 Thread Stefan Hajnoczi
On Fri, Dec 28, 2012 at 06:31:53PM +0800, Jason Wang wrote: > diff --git a/qapi-schema.json b/qapi-schema.json > index 5dfa052..583eb7c 100644 > --- a/qapi-schema.json > +++ b/qapi-schema.json > @@ -2465,7 +2465,7 @@ > { 'type': 'NetdevTapOptions', >'data': { > '*ifname': 'str', > -

[Qemu-devel] [PATCH 01/12] tap: multiqueue support

2012-12-28 Thread Jason Wang
Recently, linux support multiqueue tap which could let userspace call TUNSETIFF for a signle device many times to create multiple file descriptors as independent queues. User could also enable/disabe a specific queue through TUNSETQUEUE. The patch adds the generic infrastructure to create multique