Re: [Qemu-devel] [PATCH 01/12] qapi: add size parser to StringInputVisitor

2014-02-05 Thread Eric Blake
On 02/05/2014 10:18 AM, Paolo Bonzini wrote: > Il 05/02/2014 18:13, Andreas Färber ha scritto: >> > +error_set(errp, QERR_INVALID_PARAMETER_TYPE, name ? name : >> "null", >> > + "size"); >> >> error_setg()? > > We're still using error_set for existing errors. In this case

Re: [Qemu-devel] [PATCH 01/12] qapi: add size parser to StringInputVisitor

2014-02-05 Thread Paolo Bonzini
Il 05/02/2014 18:13, Andreas Färber ha scritto: > +error_set(errp, QERR_INVALID_PARAMETER_TYPE, name ? name : "null", > + "size"); error_setg()? We're still using error_set for existing errors. In this case, the code is taken from qdev-properties.c. Paolo Otherwi

Re: [Qemu-devel] [PATCH 01/12] qapi: add size parser to StringInputVisitor

2014-02-05 Thread Andreas Färber
Am 30.01.2014 14:09, schrieb Paolo Bonzini: > Signed-off-by: Paolo Bonzini > --- > qapi/string-input-visitor.c | 24 > 1 file changed, 24 insertions(+) > > diff --git a/qapi/string-input-visitor.c b/qapi/string-input-visitor.c > index 8f1bc41..793548a 100644 > --- a/qapi

Re: [Qemu-devel] [PATCH 01/12] qapi: add size parser to StringInputVisitor

2014-01-30 Thread Eric Blake
On 01/30/2014 06:09 AM, Paolo Bonzini wrote: > Signed-off-by: Paolo Bonzini > --- > qapi/string-input-visitor.c | 24 > 1 file changed, 24 insertions(+) Reviewed-by: Eric Blake -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://

[Qemu-devel] [PATCH 01/12] qapi: add size parser to StringInputVisitor

2014-01-30 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- qapi/string-input-visitor.c | 24 1 file changed, 24 insertions(+) diff --git a/qapi/string-input-visitor.c b/qapi/string-input-visitor.c index 8f1bc41..793548a 100644 --- a/qapi/string-input-visitor.c +++ b/qapi/string-input-visitor.c @@