Re: [Qemu-devel] [PATCH 01/11] tci: Fix build regression

2016-04-07 Thread Richard Henderson
On 04/07/2016 01:37 PM, Stefan Weil wrote: I just tested a variant with tcg_debug_assert. It creates less efficient code when debugging is disabled. Here is the code size for x86_64: with normal tcg_debug_assert: text databssdechexfilename 8293

Re: [Qemu-devel] [PATCH 01/11] tci: Fix build regression

2016-04-07 Thread Stefan Weil
Am 07.04.2016 um 21:16 schrieb Stefan Weil: > Am 07.04.2016 um 20:15 schrieb Richard Henderson: >> On 04/07/2016 08:53 AM, Sergey Fedorov wrote: >>> +/* Enable TCI assertions only when debugging TCG (and without NDEBUG >>> defined). >>> + * Without assertions, the interpreter runs much faster. */ >

Re: [Qemu-devel] [PATCH 01/11] tci: Fix build regression

2016-04-07 Thread Stefan Weil
Am 07.04.2016 um 20:15 schrieb Richard Henderson: > On 04/07/2016 08:53 AM, Sergey Fedorov wrote: >> +/* Enable TCI assertions only when debugging TCG (and without NDEBUG >> defined). >> + * Without assertions, the interpreter runs much faster. */ >> +#if defined(CONFIG_DEBUG_TCG) >> +# define tci_

Re: [Qemu-devel] [PATCH 01/11] tci: Fix build regression

2016-04-07 Thread Richard Henderson
On 04/07/2016 08:53 AM, Sergey Fedorov wrote: +/* Enable TCI assertions only when debugging TCG (and without NDEBUG defined). + * Without assertions, the interpreter runs much faster. */ +#if defined(CONFIG_DEBUG_TCG) +# define tci_assert(cond) assert(cond) +#else +# define tci_assert(cond) ((voi

[Qemu-devel] [PATCH 01/11] tci: Fix build regression

2016-04-07 Thread Sergey Fedorov
From: Stefan Weil Commit d38ea87ac54af64ef611de434d07c12dc0399216 cleaned the include statements which resulted in a wrong order of assert.h and the definition of NDEBUG in tci.c. Normally NDEBUG modifies the definition of the assert macro, but here this definition comes too late which results in