Re: [Qemu-devel] [PATCH 01/11] migration: assert colo instead of check

2018-01-03 Thread Peter Xu
On Wed, Jan 03, 2018 at 09:38:52AM +0100, Juan Quintela wrote: > Peter Xu wrote: > > When reaching here if we are still "active" it means we must be in colo > > state. Assert it instead of check it in if condition. > > I don't think so. > > > Finally I want to use "switch" here rather than lots

Re: [Qemu-devel] [PATCH 01/11] migration: assert colo instead of check

2018-01-03 Thread Juan Quintela
Peter Xu wrote: > When reaching here if we are still "active" it means we must be in colo > state. Assert it instead of check it in if condition. I don't think so. > Finally I want to use "switch" here rather than lots of complicated if > clauses. > > Signed-off-by: Peter Xu > --- > migration

[Qemu-devel] [PATCH 01/11] migration: assert colo instead of check

2018-01-02 Thread Peter Xu
When reaching here if we are still "active" it means we must be in colo state. Assert it instead of check it in if condition. Finally I want to use "switch" here rather than lots of complicated if clauses. Signed-off-by: Peter Xu --- migration/migration.c | 3 ++- 1 file changed, 2 insertions(