On Mon, May 08, 2017 at 04:13:00PM +0200, Paolo Bonzini wrote:
> !job is always checked prior to the call, drop it from here.
>
> Reviewed-by: Stefan Hajnoczi
> Signed-off-by: Paolo Bonzini
> ---
> blockjob.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/blockjob.c b
!job is always checked prior to the call, drop it from here.
Reviewed-by: Stefan Hajnoczi
Signed-off-by: Paolo Bonzini
---
blockjob.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/blockjob.c b/blockjob.c
index 6e489327ff..23022b3331 100644
--- a/blockjob.c
+++ b/blockjob.c
On 25/04/2017 01:19, John Snow wrote:
> Worth a resend to CC qemu-block, include a cover letter, and all the
> usual amenities?
The cover letter was there, but yes, I'll ensure Jeff and qemu-block are
CCed on all patches.
Paolo
Worth a resend to CC qemu-block, include a cover letter, and all the
usual amenities?
On 04/19/2017 10:42 AM, Paolo Bonzini wrote:
> !job is always checked prior to the call, drop it from here.
>
> Reviewed-by: Stefan Hajnoczi
> Signed-off-by: Paolo Bonzini
> ---
> blockjob.c | 2 +-
> 1 file
On 04/19/2017 11:12 AM, Paolo Bonzini wrote:
>
>
> On 19/04/2017 17:48, Eric Blake wrote:
>>> bool block_job_user_paused(BlockJob *job)
>>> {
>> Is it worth using some form of attribute((nonnull)) annotations on
>> various functions, to both state our intentions and let compilers help
>> us cat
On 19/04/2017 17:48, Eric Blake wrote:
>> bool block_job_user_paused(BlockJob *job)
>> {
> Is it worth using some form of attribute((nonnull)) annotations on
> various functions, to both state our intentions and let compilers help
> us catch obvious places where we are violating our intentions?
On 04/19/2017 09:42 AM, Paolo Bonzini wrote:
> !job is always checked prior to the call, drop it from here.
>
> Reviewed-by: Stefan Hajnoczi
> Signed-off-by: Paolo Bonzini
> ---
> blockjob.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/blockjob.c b/blockjob.c
> inde
!job is always checked prior to the call, drop it from here.
Reviewed-by: Stefan Hajnoczi
Signed-off-by: Paolo Bonzini
---
blockjob.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/blockjob.c b/blockjob.c
index 6e48932..23022b3 100644
--- a/blockjob.c
+++ b/blockjob.c
@@ -4
