Re: [Qemu-devel] [PATCH 01/11] NVMe: Initial commit for NVM Express device

2013-02-28 Thread Markus Armbruster
Keith Busch writes: > On Wed, 27 Feb 2013, Paolo Bonzini wrote: >> Il 27/02/2013 10:30, Andreas Färber ha scritto: [...] >> Finally, and unrelated to the code above, we usually do not add new "if" >> values. It's enough to have access via if=none & -device. In any case >> it should be a separat

Re: [Qemu-devel] [PATCH 01/11] NVMe: Initial commit for NVM Express device

2013-02-27 Thread Keith Busch
On Wed, 27 Feb 2013, Paolo Bonzini wrote: Il 27/02/2013 10:30, Andreas Färber ha scritto: +id->vwc = 1; +snprintf((char *)id->mn, sizeof(id->mn), "QEMU NVMe Ctrl"); +snprintf((char *)id->fr, sizeof(id->fr), "1.0"); +snprintf((char *)id->sn, sizeof(id->sn), "NVMeQx10%02x", n->

Re: [Qemu-devel] [PATCH 01/11] NVMe: Initial commit for NVM Express device

2013-02-27 Thread Markus Armbruster
Kevin Wolf writes: > Am 27.02.2013 um 10:48 hat Paolo Bonzini geschrieben: >> Finally, and unrelated to the code above, we usually do not add new "if" >> values. It's enough to have access via if=none & -device. In any case >> it should be a separate patch, so it's easy to drop it if that's the

Re: [Qemu-devel] [PATCH 01/11] NVMe: Initial commit for NVM Express device

2013-02-27 Thread Kevin Wolf
Am 27.02.2013 um 10:48 hat Paolo Bonzini geschrieben: > Finally, and unrelated to the code above, we usually do not add new "if" > values. It's enough to have access via if=none & -device. In any case > it should be a separate patch, so it's easy to drop it if that's the > decision. -device is a

Re: [Qemu-devel] [PATCH 01/11] NVMe: Initial commit for NVM Express device

2013-02-27 Thread Paolo Bonzini
Il 27/02/2013 10:30, Andreas Färber ha scritto: >> > +id->vwc = 1; >> > +snprintf((char *)id->mn, sizeof(id->mn), "QEMU NVMe Ctrl"); >> > +snprintf((char *)id->fr, sizeof(id->fr), "1.0"); >> > +snprintf((char *)id->sn, sizeof(id->sn), "NVMeQx10%02x", n->instance); > Does this li

Re: [Qemu-devel] [PATCH 01/11] NVMe: Initial commit for NVM Express device

2013-02-27 Thread Andreas Färber
Am 27.02.2013 01:47, schrieb Keith Busch: > NVM Express is an open standard for PCI-e attached Non-Volatile Memory > storage. This commit adds an emulated device that supports the register > interface and command set defined by this standard. The standard can > be viewed at nvmexpress.org. This ini

[Qemu-devel] [PATCH 01/11] NVMe: Initial commit for NVM Express device

2013-02-26 Thread Keith Busch
NVM Express is an open standard for PCI-e attached Non-Volatile Memory storage. This commit adds an emulated device that supports the register interface and command set defined by this standard. The standard can be viewed at nvmexpress.org. This initial commit implements the minimum amount required