Re: [Qemu-devel] [PATCH 01/10] mips-linux-user: Delete n32 and n64 signal stubs

2013-02-11 Thread Richard Henderson
On 2013-02-11 09:05, Andreas Färber wrote: We have it enabled for openSUSE despite the #warning (anyone can enable it via --target-list, so it's not entirely dead code), but since you're fixing it later in the series that seems fine with me. Ideally you could squash patches 1+2 so that there is n

Re: [Qemu-devel] [PATCH 01/10] mips-linux-user: Delete n32 and n64 signal stubs

2013-02-11 Thread Andreas Färber
Am 11.02.2013 17:02, schrieb Richard Henderson: > On 2013-02-10 10:30, Richard Henderson wrote: >> Signed-off-by: Richard Henderson > > Deleting these first makes the next patch much easier to read. > This doesn't cause any sort of compilation failure because we > have not yet enabled n32/n64 com

Re: [Qemu-devel] [PATCH 01/10] mips-linux-user: Delete n32 and n64 signal stubs

2013-02-11 Thread Peter Maydell
On 11 February 2013 16:02, Richard Henderson wrote: > On 2013-02-10 10:30, Richard Henderson wrote: >> >> Signed-off-by: Richard Henderson > > > Deleting these first makes the next patch much easier to read. > This doesn't cause any sort of compilation failure because we > have not yet enabled n3

Re: [Qemu-devel] [PATCH 01/10] mips-linux-user: Delete n32 and n64 signal stubs

2013-02-11 Thread Richard Henderson
On 2013-02-10 10:30, Richard Henderson wrote: Signed-off-by: Richard Henderson Deleting these first makes the next patch much easier to read. This doesn't cause any sort of compilation failure because we have not yet enabled n32/n64 compilation. This is dead code. r~

[Qemu-devel] [PATCH 01/10] mips-linux-user: Delete n32 and n64 signal stubs

2013-02-10 Thread Richard Henderson
Signed-off-by: Richard Henderson --- linux-user/signal.c | 58 - 1 file changed, 58 deletions(-) diff --git a/linux-user/signal.c b/linux-user/signal.c index 67c2311..b2f1d29 100644 --- a/linux-user/signal.c +++ b/linux-user/signal.c @@ -2438,6