Re: [Qemu-devel] [PATCH 01/10] ide: Break all non-qdevified controllers

2012-12-18 Thread Peter Maydell
On 18 December 2012 12:44, Markus Armbruster wrote: > Peter Maydell writes: >> We really need a better way to mark devices as "obsolete, will be >> removed/broken/etc in a future version"... > > Yes, we do. > > These devices, however, are a slightly different case: "need > maintenance, will be re

Re: [Qemu-devel] [PATCH 01/10] ide: Break all non-qdevified controllers

2012-12-18 Thread Markus Armbruster
Peter Maydell writes: > On 17 December 2012 14:05, Markus Armbruster wrote: >> The writing has been on the wall for a few years. > > ...behind a filing cabinet in a disused lavatory with a sign on the door > saying "beware of the leopard"? > > We really need a better way to mark devices as "obso

Re: [Qemu-devel] [PATCH 01/10] ide: Break all non-qdevified controllers

2012-12-18 Thread Markus Armbruster
Andreas Färber writes: > Am 17.12.2012 15:43, schrieb Markus Armbruster: >> Alexander Graf writes: >> >>> On 17.12.2012, at 15:05, Markus Armbruster wrote: >>> They complicate IDE data structures and keep getting in the way. Also, TRIM support (commit d353fb72) is broken for them, bec

Re: [Qemu-devel] [PATCH 01/10] ide: Break all non-qdevified controllers

2012-12-18 Thread Peter Maydell
On 17 December 2012 14:05, Markus Armbruster wrote: > The writing has been on the wall for a few years. ...behind a filing cabinet in a disused lavatory with a sign on the door saying "beware of the leopard"? We really need a better way to mark devices as "obsolete, will be removed/broken/etc in

Re: [Qemu-devel] [PATCH 01/10] ide: Break all non-qdevified controllers

2012-12-17 Thread Andreas Färber
Am 17.12.2012 15:43, schrieb Markus Armbruster: > Alexander Graf writes: > >> On 17.12.2012, at 15:05, Markus Armbruster wrote: >> >>> They complicate IDE data structures and keep getting in the way. >>> Also, TRIM support (commit d353fb72) is broken for them, because >>> ide_identify() accesses

Re: [Qemu-devel] [PATCH 01/10] ide: Break all non-qdevified controllers

2012-12-17 Thread Markus Armbruster
Alexander Graf writes: > On 17.12.2012, at 16:15, Markus Armbruster wrote: > >> Alexander Graf writes: >> >>> On 17.12.2012, at 15:43, Markus Armbruster wrote: >>> Alexander Graf writes: > On 17.12.2012, at 15:05, Markus Armbruster wrote: > >> They complicate IDE data

Re: [Qemu-devel] [PATCH 01/10] ide: Break all non-qdevified controllers

2012-12-17 Thread Markus Armbruster
Alexander Graf writes: > On 17.12.2012, at 15:05, Markus Armbruster wrote: > >> They complicate IDE data structures and keep getting in the way. >> Also, TRIM support (commit d353fb72) is broken for them, because >> ide_identify() accesses IDEDevice member conf, but IDEDevice exists >> only with

Re: [Qemu-devel] [PATCH 01/10] ide: Break all non-qdevified controllers

2012-12-17 Thread Alexander Graf
On 17.12.2012, at 16:15, Markus Armbruster wrote: > Alexander Graf writes: > >> On 17.12.2012, at 15:43, Markus Armbruster wrote: >> >>> Alexander Graf writes: >>> On 17.12.2012, at 15:05, Markus Armbruster wrote: > They complicate IDE data structures and keep getting in the w

Re: [Qemu-devel] [PATCH 01/10] ide: Break all non-qdevified controllers

2012-12-17 Thread Markus Armbruster
Alexander Graf writes: > On 17.12.2012, at 15:43, Markus Armbruster wrote: > >> Alexander Graf writes: >> >>> On 17.12.2012, at 15:05, Markus Armbruster wrote: >>> They complicate IDE data structures and keep getting in the way. Also, TRIM support (commit d353fb72) is broken for them

Re: [Qemu-devel] [PATCH 01/10] ide: Break all non-qdevified controllers

2012-12-17 Thread Alexander Graf
On 17.12.2012, at 15:43, Markus Armbruster wrote: > Alexander Graf writes: > >> On 17.12.2012, at 15:05, Markus Armbruster wrote: >> >>> They complicate IDE data structures and keep getting in the way. >>> Also, TRIM support (commit d353fb72) is broken for them, because >>> ide_identify() acce

[Qemu-devel] [PATCH 01/10] ide: Break all non-qdevified controllers

2012-12-17 Thread Markus Armbruster
They complicate IDE data structures and keep getting in the way. Also, TRIM support (commit d353fb72) is broken for them, because ide_identify() accesses IDEDevice member conf, but IDEDevice exists only with qdevified controllers. The non-qdevified controllers are still there, but attempting to co

Re: [Qemu-devel] [PATCH 01/10] ide: Break all non-qdevified controllers

2012-12-17 Thread Alexander Graf
On 17.12.2012, at 15:05, Markus Armbruster wrote: > They complicate IDE data structures and keep getting in the way. > Also, TRIM support (commit d353fb72) is broken for them, because > ide_identify() accesses IDEDevice member conf, but IDEDevice exists > only with qdevified controllers. > > The