On Thu, Mar 23, 2017 at 06:39:19PM +0100, Paolo Bonzini wrote:
> !job is always checked prior to the call, drop it from here.
>
> Signed-off-by: Paolo Bonzini
> ---
> blockjob.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Stefan Hajnoczi
signature.asc
Description: PG
On 04/07/2017 06:54 PM, Philippe Mathieu-Daudé wrote:
> Hi Paolo,
>
> On 03/23/2017 02:39 PM, Paolo Bonzini wrote:
>> !job is always checked prior to the call, drop it from here.
>
> I agree with you this is currently true, *but* block_job_user_paused()
> is exported in "block/blockjob.h" so an
Hi Paolo,
On 03/23/2017 02:39 PM, Paolo Bonzini wrote:
!job is always checked prior to the call, drop it from here.
I agree with you this is currently true, *but* block_job_user_paused()
is exported in "block/blockjob.h" so any future access (external to
blockdev.c) could eventually happen w
On 03/23/2017 01:39 PM, Paolo Bonzini wrote:
> !job is always checked prior to the call, drop it from here.
>
> Signed-off-by: Paolo Bonzini
> ---
> blockjob.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/blockjob.c b/blockjob.c
> index 9b619f385..a9fb624 100644
>
!job is always checked prior to the call, drop it from here.
Signed-off-by: Paolo Bonzini
---
blockjob.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/blockjob.c b/blockjob.c
index 9b619f385..a9fb624 100644
--- a/blockjob.c
+++ b/blockjob.c
@@ -480,7 +480,7 @@ static bool b