Re: [Qemu-devel] [PATCH 00/24] per-directory Makefile snippets, limit vpath abuse

2012-06-05 Thread Paolo Bonzini
Il 04/06/2012 20:58, Eric Blake ha scritto: > On 06/04/2012 12:52 PM, Lluís Vilanova wrote: > > As before, I dislike the use of the filename "Makefile" for files that > are not self-contained. If make is called from that deep directory, it > leads to undefined results. > >> >> Naming

Re: [Qemu-devel] [PATCH 00/24] per-directory Makefile snippets, limit vpath abuse

2012-06-04 Thread Eric Blake
On 06/04/2012 12:52 PM, Lluís Vilanova wrote: As before, I dislike the use of the filename "Makefile" for files that are not self-contained. If make is called from that deep directory, it leads to undefined results. > > Naming them as *.mak makes some common editors interpret the

Re: [Qemu-devel] [PATCH 00/24] per-directory Makefile snippets, limit vpath abuse

2012-06-04 Thread Lluís Vilanova
Paolo Bonzini writes: > Il 04/06/2012 00:57, Anthony Liguori ha scritto: >>> >>> As before, I dislike the use of the filename "Makefile" for files that >>> are not self-contained. If make is called from that deep directory, it >>> leads to undefined results. Either we must make sure through some

Re: [Qemu-devel] [PATCH 00/24] per-directory Makefile snippets, limit vpath abuse

2012-06-04 Thread Lluís Vilanova
Paolo Bonzini writes: > One source of complexity in the QEMU source is that we have a very > shallow tree for a source code of over 750,000 lines of code. In > fact, one third of these lines alone is in one directory, hw/. > As a prerequisite to cleaning up the structure, but as a worthwhile > s

Re: [Qemu-devel] [PATCH 00/24] per-directory Makefile snippets, limit vpath abuse

2012-06-03 Thread Paolo Bonzini
Il 04/06/2012 00:57, Anthony Liguori ha scritto: >> >> As before, I dislike the use of the filename "Makefile" for files that >> are not self-contained. If make is called from that deep directory, it >> leads to undefined results. Either we must make sure through some clever >> ifeq'ery and a local

Re: [Qemu-devel] [PATCH 00/24] per-directory Makefile snippets, limit vpath abuse

2012-06-03 Thread Anthony Liguori
On 06/04/2012 06:40 AM, Andreas Färber wrote: Am 03.06.2012 14:25, schrieb Paolo Bonzini: One source of complexity in the QEMU source is that we have a very shallow tree for a source code of over 750,000 lines of code. In fact, one third of these lines alone is in one directory, hw/. As a prer

Re: [Qemu-devel] [PATCH 00/24] per-directory Makefile snippets, limit vpath abuse

2012-06-03 Thread Anthony Liguori
On 06/03/2012 08:25 PM, Paolo Bonzini wrote: One source of complexity in the QEMU source is that we have a very shallow tree for a source code of over 750,000 lines of code. In fact, one third of these lines alone is in one directory, hw/. As a prerequisite to cleaning up the structure, but as

Re: [Qemu-devel] [PATCH 00/24] per-directory Makefile snippets, limit vpath abuse

2012-06-03 Thread Andreas Färber
Am 03.06.2012 14:25, schrieb Paolo Bonzini: > One source of complexity in the QEMU source is that we have a very > shallow tree for a source code of over 750,000 lines of code. In > fact, one third of these lines alone is in one directory, hw/. > > As a prerequisite to cleaning up the structure,

Re: [Qemu-devel] [PATCH 00/24] per-directory Makefile snippets, limit vpath abuse

2012-06-03 Thread Paolo Bonzini
Il 03/06/2012 15:31, Blue Swirl ha scritto: >> > The series is entirely bisectable, and mostly consists of boring patches. >> > If the concept is accepted, I would like to get it in as soon as possible. >> > I have a few other cleanups on top (I stopped once I undid the diffstat >> > of this series

Re: [Qemu-devel] [PATCH 00/24] per-directory Makefile snippets, limit vpath abuse

2012-06-03 Thread Blue Swirl
On Sun, Jun 3, 2012 at 12:25 PM, Paolo Bonzini wrote: > One source of complexity in the QEMU source is that we have a very > shallow tree for a source code of over 750,000 lines of code.  In > fact, one third of these lines alone is in one directory, hw/. > > As a prerequisite to cleaning up the s

[Qemu-devel] [PATCH 00/24] per-directory Makefile snippets, limit vpath abuse

2012-06-03 Thread Paolo Bonzini
One source of complexity in the QEMU source is that we have a very shallow tree for a source code of over 750,000 lines of code. In fact, one third of these lines alone is in one directory, hw/. As a prerequisite to cleaning up the structure, but as a worthwhile step on its own, this patchset cle