On Tue, Nov 10, 2009 at 11:38:49PM +, Paul Brook wrote:
> > > Some of the generated tcg code is not very optimal, for example a
> > > single vld4.8 instruction can generate over 250 tcg ops. I did some
> > > optimizations and got it under 200 but do you think it could be an
> > > issue that a s
> On the code itself, I don't really like the remaining, new_tmp(),
> dead_tmp(), and even more the fact that some functions can allocate
> (e.g load_reg) or free (e.g. store_reg) some TCG variables implicitely.
> This is a way to make errors by reallocating or forgetting to free some
>
> variable
> > Some of the generated tcg code is not very optimal, for example a
> > single vld4.8 instruction can generate over 250 tcg ops. I did some
> > optimizations and got it under 200 but do you think it could be an
> > issue that a single instruction can expand to so many tcg ops? I mean
> > besides
On Oct 19, 2009, at 16:23, ext Aurelien Jarno wrote:
>> I think I have a couple of other fixes and patches on top of that as
>> well, but I'd rather wait until you get this bunch committed and then
>> format the patches against the new mainline so that they apply.
>
> Thanks I have seen your patc
On Mon, Oct 19, 2009 at 08:23:11AM +0200, juha.riihim...@nokia.com wrote:
> >> Apart from the points you have raised about specific patches there
> >> were few more minor bugs in the series spotted by Juha Riihimäki
> >> . A fix is available at
> >> http://repo.or.cz/w/qemu/navara.git?a=commit;h=2c
On Mon, Oct 19, 2009 at 8:23 AM, wrote:
>
> I think I have a couple of other fixes and patches on top of that as
> well, but I'd rather wait until you get this bunch committed and then
> format the patches against the new mainline so that they apply.
It's already been committed (the commit notif
>> Apart from the points you have raised about specific patches there
>> were few more minor bugs in the series spotted by Juha Riihimäki
>> . A fix is available at
>> http://repo.or.cz/w/qemu/navara.git?a=commit;h=2ce696baa6fc5d99522cf387b6a4913807fd43ed
>
> One of the fix was already in my branch
