Re: [Qemu-devel] [PATCH 00/17] Update to adding an IPMI device to qemu

2015-04-27 Thread Corey Minyard
On 04/26/2015 06:39 AM, Andreas Färber wrote: > Am 24.04.2015 um 01:11 schrieb Eric Blake: >> On 04/23/2015 04:57 PM, miny...@acm.org wrote: >>> The major changes from last time are: >> That says this series should probably be named v2 (git >> format-patch/send-email -v2) or later, as part of the s

Re: [Qemu-devel] [PATCH 00/17] Update to adding an IPMI device to qemu

2015-04-26 Thread Paolo Bonzini
On 26/04/2015 13:39, Andreas Färber wrote: >> That says this series should probably be named v2 (git >> format-patch/send-email -v2) or later, as part of the subject >> line. If the previous version is more than a couple weeks ago, >> it's also nice (but not required) to provide a URL to the >>

Re: [Qemu-devel] [PATCH 00/17] Update to adding an IPMI device to qemu

2015-04-26 Thread Andreas Färber
Am 24.04.2015 um 01:11 schrieb Eric Blake: > On 04/23/2015 04:57 PM, miny...@acm.org wrote: >> The major changes from last time are: > > That says this series should probably be named v2 (git > format-patch/send-email -v2) or later, as part of the subject line. If > the previous version is more th

Re: [Qemu-devel] [PATCH 00/17] Update to adding an IPMI device to qemu

2015-04-24 Thread Corey Minyard
On 04/24/2015 04:38 AM, Paolo Bonzini wrote: > > On 24/04/2015 00:57, miny...@acm.org wrote: >> The major changes from last time are: >> >> * Don't use callbacks for adding firmware tables, provide binary >> blobs instead. >> >> * Add the SSDT as a separate table. >> >> * Modify the BIOS tests to

Re: [Qemu-devel] [PATCH 00/17] Update to adding an IPMI device to qemu

2015-04-24 Thread Paolo Bonzini
On 24/04/2015 00:57, miny...@acm.org wrote: > The major changes from last time are: > > * Don't use callbacks for adding firmware tables, provide binary > blobs instead. > > * Add the SSDT as a separate table. > > * Modify the BIOS tests to test for the IPMI tables. I disagree with both of

Re: [Qemu-devel] [PATCH 00/17] Update to adding an IPMI device to qemu

2015-04-23 Thread Eric Blake
On 04/23/2015 04:57 PM, miny...@acm.org wrote: > The major changes from last time are: That says this series should probably be named v2 (git format-patch/send-email -v2) or later, as part of the subject line. If the previous version is more than a couple weeks ago, it's also nice (but not require

[Qemu-devel] [PATCH 00/17] Update to adding an IPMI device to qemu

2015-04-23 Thread minyard
The major changes from last time are: * Don't use callbacks for adding firmware tables, provide binary blobs instead. * Add the SSDT as a separate table. * Modify the BIOS tests to test for the IPMI tables. -corey