Re: [Qemu-devel] [PATCH 00/16] QEMU vhost-scsi support

2012-04-24 Thread ronnie sahlberg
On Tue, Apr 24, 2012 at 7:13 PM, Stefan Hajnoczi wrote: > On Tue, Apr 24, 2012 at 8:05 AM, Paolo Bonzini wrote: >> Il 24/04/2012 06:21, ronnie sahlberg ha scritto: >>> Hi Stefan, >>> >>> A little bit off-topic but >>> >>> When you design the proper place and API to plug virt-scsi into an >>> exte

Re: [Qemu-devel] [PATCH 00/16] QEMU vhost-scsi support

2012-04-24 Thread Stefan Hajnoczi
On Tue, Apr 24, 2012 at 8:05 AM, Paolo Bonzini wrote: > Il 24/04/2012 06:21, ronnie sahlberg ha scritto: >> Hi Stefan, >> >> A little bit off-topic but >> >> When you design the proper place and API to plug virt-scsi into an >> external SCSI parser outside of qemu like the target in the kernel ...

Re: [Qemu-devel] [PATCH 00/16] QEMU vhost-scsi support

2012-04-24 Thread Paolo Bonzini
Il 24/04/2012 06:21, ronnie sahlberg ha scritto: > Hi Stefan, > > A little bit off-topic but > > When you design the proper place and API to plug virt-scsi into an > external SCSI parser outside of qemu like the target in the kernel ... > > It would be very nice if one could also plug virt-scsi

Re: [Qemu-devel] [PATCH 00/16] QEMU vhost-scsi support

2012-04-23 Thread ronnie sahlberg
On Mon, Apr 23, 2012 at 7:33 PM, Stefan Hajnoczi wrote: > On Sat, Apr 21, 2012 at 9:51 AM, Nicholas A. Bellinger > wrote: >> On Fri, 2012-04-20 at 12:09 +0100, Stefan Hajnoczi wrote: >>> On Fri, Apr 20, 2012 at 8:46 AM, Paolo Bonzini wrote: >>> > Il 20/04/2012 09:00, Nicholas A. Bellinger ha scr

Re: [Qemu-devel] [PATCH 00/16] QEMU vhost-scsi support

2012-04-23 Thread Stefan Hajnoczi
On Sat, Apr 21, 2012 at 9:51 AM, Nicholas A. Bellinger wrote: > On Fri, 2012-04-20 at 12:09 +0100, Stefan Hajnoczi wrote: >> On Fri, Apr 20, 2012 at 8:46 AM, Paolo Bonzini wrote: >> > Il 20/04/2012 09:00, Nicholas A. Bellinger ha scritto: > > > >> > - no support for migration (there can be pendi

Re: [Qemu-devel] [PATCH 00/16] QEMU vhost-scsi support

2012-04-21 Thread Nicholas A. Bellinger
On Fri, 2012-04-20 at 12:09 +0100, Stefan Hajnoczi wrote: > On Fri, Apr 20, 2012 at 8:46 AM, Paolo Bonzini wrote: > > Il 20/04/2012 09:00, Nicholas A. Bellinger ha scritto: > > - no support for migration (there can be pending SCSI requests at > > migration time, that need to be restarted on the

Re: [Qemu-devel] [PATCH 00/16] QEMU vhost-scsi support

2012-04-20 Thread Stefan Hajnoczi
On Fri, Apr 20, 2012 at 8:46 AM, Paolo Bonzini wrote: > Il 20/04/2012 09:00, Nicholas A. Bellinger ha scritto: >> On Thu, 2012-04-19 at 19:20 -0500, Anthony Liguori wrote: >>> TCM runs in the absolute most privileged context possible.  When you're >>> dealing >>> with extremely hostile input, it'

Re: [Qemu-devel] [PATCH 00/16] QEMU vhost-scsi support

2012-04-20 Thread Paolo Bonzini
Il 20/04/2012 09:00, Nicholas A. Bellinger ha scritto: > On Thu, 2012-04-19 at 19:20 -0500, Anthony Liguori wrote: >> TCM runs in the absolute most privileged context possible. When you're >> dealing >> with extremely hostile input, it's pretty obvious that you want to run it in >> the >> lowe

Re: [Qemu-devel] [PATCH 00/16] QEMU vhost-scsi support

2012-04-20 Thread Nicholas A. Bellinger
On Fri, 2012-04-20 at 17:50 +1000, ronnie sahlberg wrote: > On Fri, Apr 20, 2012 at 5:00 PM, Nicholas A. Bellinger > wrote: > > On Thu, 2012-04-19 at 19:20 -0500, Anthony Liguori wrote: > >> Hi Nicholas, > >> > > The argument that a SCSI target for virtual machines is so complex that > > it can

Re: [Qemu-devel] [PATCH 00/16] QEMU vhost-scsi support

2012-04-20 Thread ronnie sahlberg
On Fri, Apr 20, 2012 at 5:00 PM, Nicholas A. Bellinger wrote: > On Thu, 2012-04-19 at 19:20 -0500, Anthony Liguori wrote: >> Hi Nicholas, >> >> On 04/19/2012 06:53 PM, Nicholas A. Bellinger wrote: >> > On Thu, 2012-04-19 at 07:30 -0500, Anthony Liguori wrote: >> >> However, for storage, be it scsi

Re: [Qemu-devel] [PATCH 00/16] QEMU vhost-scsi support

2012-04-20 Thread Nicholas A. Bellinger
On Thu, 2012-04-19 at 19:20 -0500, Anthony Liguori wrote: > Hi Nicholas, > > On 04/19/2012 06:53 PM, Nicholas A. Bellinger wrote: > > On Thu, 2012-04-19 at 07:30 -0500, Anthony Liguori wrote: > >> However, for storage, be it scsi or direct access, the same problem really > >> doesn't exist. There

Re: [Qemu-devel] [PATCH 00/16] QEMU vhost-scsi support

2012-04-19 Thread Zhi Yong Wu
I have pushed the rebased QEMU codes and tcm_vhost codes to my git tree. Perhaps some one is interested in playing with it. 1.) my kernel git g...@github.com:wuzhy/linux.git tcm_vhost https://github.com/wuzhy/linux/commits/tcm_vhost 2.) my QEMU git g...@github.com:wuzhy/qemu.git vhost-scsi https:/

Re: [Qemu-devel] [PATCH 00/16] QEMU vhost-scsi support

2012-04-19 Thread Nicholas A. Bellinger
On Thu, 2012-04-19 at 07:30 -0500, Anthony Liguori wrote: > Hi, > Hi Anthony, > As I've mentioned before in the past, I will apply vhost-* without an > extremely > compelling argument for it. > > The reason we ultimately settled on vhost-net is that in the absence of a > fundamental change i

Re: [Qemu-devel] [PATCH 00/16] QEMU vhost-scsi support

2012-04-19 Thread Anthony Liguori
Hi Nicholas, On 04/19/2012 06:53 PM, Nicholas A. Bellinger wrote: On Thu, 2012-04-19 at 07:30 -0500, Anthony Liguori wrote: However, for storage, be it scsi or direct access, the same problem really doesn't exist. There isn't an obvious benefit to being in the kernel. In the modern Linux v3

Re: [Qemu-devel] [PATCH 00/16] QEMU vhost-scsi support

2012-04-19 Thread Anthony Liguori
Hi, As I've mentioned before in the past, I will apply vhost-* without an extremely compelling argument for it. The reason we ultimately settled on vhost-net is that in the absence of a fundamental change in the userspace networking interface (with something like VJ channels), it's extremely

Re: [Qemu-devel] [PATCH 00/16] QEMU vhost-scsi support

2012-04-19 Thread Zhi Yong Wu
On Thu, Apr 19, 2012 at 4:43 PM, Paolo Bonzini wrote: > Il 19/04/2012 10:19, Zhi Yong Wu ha scritto: >>> > >>> > 2) The series uses vhost-scsi unconditionally, as far as I can tell.  So >> Perhaps there're some cleanup work to do, but it use vhost-scsi >> *conditionally*. In virtio_scsi_init(), yo

Re: [Qemu-devel] [PATCH 00/16] QEMU vhost-scsi support

2012-04-19 Thread Zhi Yong Wu
On Thu, Apr 19, 2012 at 4:43 PM, Paolo Bonzini wrote: > Il 19/04/2012 10:19, Zhi Yong Wu ha scritto: >>> > >>> > 2) The series uses vhost-scsi unconditionally, as far as I can tell.  So >> Perhaps there're some cleanup work to do, but it use vhost-scsi >> *conditionally*. In virtio_scsi_init(), yo

Re: [Qemu-devel] [PATCH 00/16] QEMU vhost-scsi support

2012-04-19 Thread Paolo Bonzini
Il 19/04/2012 10:19, Zhi Yong Wu ha scritto: >> > >> > 2) The series uses vhost-scsi unconditionally, as far as I can tell. So > Perhaps there're some cleanup work to do, but it use vhost-scsi > *conditionally*. In virtio_scsi_init(), you can see the code as below: > if (s->vhost_scsi) { >

Re: [Qemu-devel] [PATCH 00/16] QEMU vhost-scsi support

2012-04-19 Thread Zhi Yong Wu
On Thu, Apr 19, 2012 at 4:19 PM, Zhi Yong Wu wrote: > On Thu, Apr 19, 2012 at 3:16 PM, Paolo Bonzini wrote: >> Il 19/04/2012 04:38, zwu.ker...@gmail.com ha scritto: >>> From: Zhi Yong Wu >>> >>> The patchset was developed originally by Stefan about one year ago. I >>> now rebase it to latest qem

Re: [Qemu-devel] [PATCH 00/16] QEMU vhost-scsi support

2012-04-19 Thread Zhi Yong Wu
On Thu, Apr 19, 2012 at 3:16 PM, Paolo Bonzini wrote: > Il 19/04/2012 04:38, zwu.ker...@gmail.com ha scritto: >> From: Zhi Yong Wu >> >> The patchset was developed originally by Stefan about one year ago. I >> now rebase it to latest qemu.git/master and fixed some issues to make >> it work agains

Re: [Qemu-devel] [PATCH 00/16] QEMU vhost-scsi support

2012-04-19 Thread Paolo Bonzini
Il 19/04/2012 04:38, zwu.ker...@gmail.com ha scritto: > From: Zhi Yong Wu > > The patchset was developed originally by Stefan about one year ago. I > now rebase it to latest qemu.git/master and fixed some issues to make > it work against tcm_vhost and virtio_scsi driver. But there are still > som

[Qemu-devel] [PATCH 00/16] QEMU vhost-scsi support

2012-04-18 Thread zwu . kernel
From: Zhi Yong Wu The patchset was developed originally by Stefan about one year ago. I now rebase it to latest qemu.git/master and fixed some issues to make it work against tcm_vhost and virtio_scsi driver. But there are still some issues to fix. Let us make more effort later. Stefan Hajnocz