Re: [Qemu-devel] [PATCH 00/12] nbd improvements

2011-09-14 Thread Kevin Wolf
Am 08.09.2011 17:24, schrieb Paolo Bonzini: > I find nbd quite useful to test migration, but it is limited: > it can only do synchronous operation, it is not safe because it > does not support flush, and it has no discard either. qemu-nbd > is also limited to 1MB requests, and the nbd block driver

Re: [Qemu-devel] [PATCH 00/12] nbd improvements

2011-09-09 Thread Nicholas Thomas
On 09/09/11 12:04, Kevin Wolf wrote: > Good to see agreement here. Do you think that Paolo's patches need to be > changed or can we do everything else on top? A few things have come up on a third read, actually. I'll respond in due course to the appropriate patch. > We do have some timer stubs i

Re: [Qemu-devel] [PATCH 00/12] nbd improvements

2011-09-09 Thread Kevin Wolf
Am 09.09.2011 12:50, schrieb Nicholas Thomas: > On Fri, 2011-09-09 at 12:29 +0200, Paolo Bonzini wrote: >> On 09/09/2011 11:00 AM, Kevin Wolf wrote: >>> There is anonther patch enabling AIO for NBD on the list [1], by >>> Nicholas Thomas (CCed), that lacked review so far. Can you guys please >>> re

Re: [Qemu-devel] [PATCH 00/12] nbd improvements

2011-09-09 Thread Paolo Bonzini
On 09/09/2011 12:50 PM, Nicholas Thomas wrote: > On the other hand, Nicholas's work includes timeout and reconnect. I'm > not sure how complicated it is to include it in my series, but probably > not much. With coroutines, preserving the list of outstanding I/O > requests is done implicitly

Re: [Qemu-devel] [PATCH 00/12] nbd improvements

2011-09-09 Thread Nicholas Thomas
On Fri, 2011-09-09 at 12:29 +0200, Paolo Bonzini wrote: > On 09/09/2011 11:00 AM, Kevin Wolf wrote: > > There is anonther patch enabling AIO for NBD on the list [1], by > > Nicholas Thomas (CCed), that lacked review so far. Can you guys please > > review each others approach and then converge on a

Re: [Qemu-devel] [PATCH 00/12] nbd improvements

2011-09-09 Thread Kevin Wolf
Am 09.09.2011 12:29, schrieb Paolo Bonzini: > On 09/09/2011 11:00 AM, Kevin Wolf wrote: >> There is anonther patch enabling AIO for NBD on the list [1], by >> Nicholas Thomas (CCed), that lacked review so far. Can you guys please >> review each others approach and then converge on a solution? I gue

Re: [Qemu-devel] [PATCH 00/12] nbd improvements

2011-09-09 Thread Paolo Bonzini
On 09/09/2011 11:00 AM, Kevin Wolf wrote: There is anonther patch enabling AIO for NBD on the list [1], by Nicholas Thomas (CCed), that lacked review so far. Can you guys please review each others approach and then converge on a solution? I guess Paolo's patches 1-7 can be applied in any case, pr

Re: [Qemu-devel] [PATCH 00/12] nbd improvements

2011-09-09 Thread Kevin Wolf
Am 08.09.2011 17:24, schrieb Paolo Bonzini: > I find nbd quite useful to test migration, but it is limited: > it can only do synchronous operation, it is not safe because it > does not support flush, and it has no discard either. qemu-nbd > is also limited to 1MB requests, and the nbd block driver

[Qemu-devel] [PATCH 00/12] nbd improvements

2011-09-08 Thread Paolo Bonzini
I find nbd quite useful to test migration, but it is limited: it can only do synchronous operation, it is not safe because it does not support flush, and it has no discard either. qemu-nbd is also limited to 1MB requests, and the nbd block driver does not take this into account. Luckily, flush/FU