Re: [Qemu-devel] [PATCH 0/8] machine: query machine properties rather than qemu opts

2015-03-04 Thread Marcel Apfelbaum
On 02/25/2015 01:55 PM, Marcel Apfelbaum wrote: On 02/04/2015 05:43 PM, Marcel Apfelbaum wrote: Commit e79d5a6 ("machine: remove qemu_machine_opts global list") removed option descriptions from the -machine QemuOptsList to avoid repeating MachineState's QOM properties. This results in a Qemu c

Re: [Qemu-devel] [PATCH 0/8] machine: query machine properties rather than qemu opts

2015-02-25 Thread Marcel Apfelbaum
On 02/04/2015 05:43 PM, Marcel Apfelbaum wrote: Commit e79d5a6 ("machine: remove qemu_machine_opts global list") removed option descriptions from the -machine QemuOptsList to avoid repeating MachineState's QOM properties. This results in a Qemu crash if a non string option is queried using qemu

Re: [Qemu-devel] [PATCH 0/8] machine: query machine properties rather than qemu opts

2015-02-04 Thread Christian Borntraeger
Am 04.02.2015 um 22:35 schrieb Marcel Apfelbaum: [...] >> Would a function there that does gets >> S390_CCW_MACHINE(current_machine)->aes_key_wrap >> considered ok, or do we need to pollute hw/core/machine.c with architecture >> specific >> options? > We surely don't add this to hw/core/machine.

Re: [Qemu-devel] [PATCH 0/8] machine: query machine properties rather than qemu opts

2015-02-04 Thread Marcel Apfelbaum
On 02/04/2015 09:45 PM, Christian Borntraeger wrote: Am 04.02.2015 um 16:43 schrieb Marcel Apfelbaum: Commit e79d5a6 ("machine: remove qemu_machine_opts global list") removed option descriptions from the -machine QemuOptsList to avoid repeating MachineState's QOM properties. This results in a

Re: [Qemu-devel] [PATCH 0/8] machine: query machine properties rather than qemu opts

2015-02-04 Thread Christian Borntraeger
Am 04.02.2015 um 16:43 schrieb Marcel Apfelbaum: > Commit e79d5a6 ("machine: remove qemu_machine_opts global list") removed > option > descriptions from the -machine QemuOptsList to avoid repeating MachineState's > QOM properties. > > This results in a Qemu crash if a non string option is querie

[Qemu-devel] [PATCH 0/8] machine: query machine properties rather than qemu opts

2015-02-04 Thread Marcel Apfelbaum
Commit e79d5a6 ("machine: remove qemu_machine_opts global list") removed option descriptions from the -machine QemuOptsList to avoid repeating MachineState's QOM properties. This results in a Qemu crash if a non string option is queried using qemu opts. Fix this by querying machine properties thr

Re: [Qemu-devel] [PATCH 0/8] machine: query machine properties rather than qemu opts

2015-02-04 Thread Paolo Bonzini
On 04/02/2015 16:43, Marcel Apfelbaum wrote: > Commit e79d5a6 ("machine: remove qemu_machine_opts global list") removed > option > descriptions from the -machine QemuOptsList to avoid repeating MachineState's > QOM properties. > > This results in a Qemu crash if a non string option is queried