Re: [Qemu-devel] [PATCH 0/7] timer: move APIs together according to their category

2014-02-27 Thread Alex Bligh
On 25 Feb 2014, at 13:36, Xuebing Wang wrote: > There are 6 categories of APIs: > - QEMUClockType > - QEMUTimerList > - QEMUTimerListGroup > - QEMUTimer > - General utility functions > - Low level clock functions > > Problems / solutions with previous API implementations: > 1) Can not think of c

Re: [Qemu-devel] [PATCH 0/7] timer: move APIs together according to their category

2014-02-25 Thread Paolo Bonzini
Il 25/02/2014 17:25, Alex Bligh ha scritto: I'm generally in favour of this patch set or something like it. It's nicely constrained to 2 include files. It appears to touch no code. And it appears to makes things tidier. Stefan / Paolo? If you agree I will review in greater detail. Sure, any h

Re: [Qemu-devel] [PATCH 0/7] timer: move APIs together according to their category

2014-02-25 Thread Alex Bligh
> > This patchset includes below changes: > - put QEMUTimerList related functions together and make them private > - put QEMUClockType related functions together > - move QEMUTimerListGroup function to be below QEMUClockType > - put QEMUTimer related functions together > - put general utility func

[Qemu-devel] [PATCH 0/7] timer: move APIs together according to their category

2014-02-25 Thread Xuebing Wang
There are 6 categories of APIs: - QEMUClockType - QEMUTimerList - QEMUTimerListGroup - QEMUTimer - General utility functions - Low level clock functions Problems / solutions with previous API implementations: 1) Can not think of cases that we need QEMUTimerList APIs. Reference: kernel_tree/Doc