Re: [Qemu-devel] [PATCH 0/7] atapi: change unlimited recursion to while loop

2018-06-06 Thread John Snow
On 06/06/2018 03:09 PM, John Snow wrote: > Real hardware doesn't have an unlimited stack, so the unlimited > recursion in the ATAPI code smells a bit. In fact, the call to > ide_transfer_start easily becomes a tail call with a small change > to the code (patch 5); however, we also need to turn

Re: [Qemu-devel] [PATCH 0/7] atapi: change unlimited recursion to while loop

2018-06-06 Thread John Snow
MEH I forgot to v2 this. On 06/06/2018 03:09 PM, John Snow wrote: > Real hardware doesn't have an unlimited stack, so the unlimited > recursion in the ATAPI code smells a bit. In fact, the call to > ide_transfer_start easily becomes a tail call with a small change > to the code (patch 5); however

[Qemu-devel] [PATCH 0/7] atapi: change unlimited recursion to while loop

2018-06-06 Thread John Snow
Real hardware doesn't have an unlimited stack, so the unlimited recursion in the ATAPI code smells a bit. In fact, the call to ide_transfer_start easily becomes a tail call with a small change to the code (patch 5); however, we also need to turn the call back to ide_atapi_cmd_reply_end into anothe