Re: [Qemu-devel] [PATCH 0/7] Improve buffer_is_zero

2016-08-25 Thread Vijay Kilari
On Thu, Aug 25, 2016 at 12:07 PM, Vijay Kilari wrote: > Hi Richard, > > Migration fails on arm64 with these patches. > On the destination VM, follow errors are appearing. > > qemu-system-aarch64: VQ 0 size 0x400 Guest index 0x0 inconsistent with > Host index 0x1937: delta 0xe6c9 > qemu-system-aa

Re: [Qemu-devel] [PATCH 0/7] Improve buffer_is_zero

2016-08-24 Thread Vijay Kilari
Hi Richard, Migration fails on arm64 with these patches. On the destination VM, follow errors are appearing. qemu-system-aarch64: VQ 0 size 0x400 Guest index 0x0 inconsistent with Host index 0x1937: delta 0xe6c9 qemu-system-aarch64: error while loading state for instance 0x0 of device 'virtio-m

Re: [Qemu-devel] [PATCH 0/7] Improve buffer_is_zero

2016-08-24 Thread Paolo Bonzini
- Original Message - > From: "Richard Henderson" > To: "Paolo Bonzini" , qemu-devel@nongnu.org > Cc: "peter maydell" , qemu-...@nongnu.org, > f...@redhat.com, "vijay kilari" > > Sent: Wednesday, August 24, 2016 4:53:37 PM >

Re: [Qemu-devel] [PATCH 0/7] Improve buffer_is_zero

2016-08-24 Thread Richard Henderson
On 08/23/2016 09:38 PM, Paolo Bonzini wrote: On 24/08/2016 06:30, no-re...@patchew.org wrote: ERROR: Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt #44: FILE: util/cutils.c:289: +__asm volatile("vmovdqu -0x80(%1),%0\n\t" Other errors can be ignor

Re: [Qemu-devel] [PATCH 0/7] Improve buffer_is_zero

2016-08-24 Thread Peter Maydell
On 24 August 2016 at 12:45, Paolo Bonzini wrote: > It does save a level of indirection after the first call AFAIK, but > it shouldn't be measurable. It's worse on first call, but I don't think the subsequent calls are better than straight pointer-indirection. It's been a while since I looked thou

Re: [Qemu-devel] [PATCH 0/7] Improve buffer_is_zero

2016-08-24 Thread Paolo Bonzini
> On 24 August 2016 at 11:26, Adam Richter wrote: > > I hope that that consideration, combined with the micro-costs to > > readability and portability of using and ELF specific and perhaps > > currently GCC specific feature might tip the balance against the > > savings of a level of function call

Re: [Qemu-devel] [PATCH 0/7] Improve buffer_is_zero

2016-08-24 Thread Peter Maydell
On 24 August 2016 at 11:26, Adam Richter wrote: > I hope that that consideration, combined with the micro-costs to > readability and portability of using and ELF specific and perhaps > currently GCC specific feature might tip the balance against the > savings of a level of function call indirectio

Re: [Qemu-devel] [PATCH 0/7] Improve buffer_is_zero

2016-08-24 Thread Adam Richter
> * Richard Henderson (r...@twiddle.net) wrote: >> Patches 1-3 remove the use of ifunc from the implementation. [...] I am not a qemu developer, but I wanted to write in support of removing the use of ifunc. I filed a glibc bug at https://sourceware.org/bugzilla/show_bug.cgi?id=20480 that I actua

Re: [Qemu-devel] [PATCH 0/7] Improve buffer_is_zero

2016-08-24 Thread Dr. David Alan Gilbert
cc'ing in Liang Li who did the original avx2 code. Dave * Richard Henderson (r...@twiddle.net) wrote: > Patches 1-3 remove the use of ifunc from the implementation. > > Patch 5 adjusts the x86 implementation a bit more to take > advantage of ptest (in sse4.1) and unaligned accesses (in avx1).

Re: [Qemu-devel] [PATCH 0/7] Improve buffer_is_zero

2016-08-23 Thread Paolo Bonzini
On 24/08/2016 06:30, no-re...@patchew.org wrote: > ERROR: Use of volatile is usually wrong: see > Documentation/volatile-considered-harmful.txt > #44: FILE: util/cutils.c:289: > +__asm volatile("vmovdqu -0x80(%1),%0\n\t" Other errors can be ignored, but please use __asm__ __volatile__ h

Re: [Qemu-devel] [PATCH 0/7] Improve buffer_is_zero

2016-08-23 Thread no-reply
Hi, Your series seems to have some coding style problems. See output below for more information: Message-id: 1472012279-20581-1-git-send-email-...@twiddle.net Subject: [Qemu-devel] [PATCH 0/7] Improve buffer_is_zero Type: series === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git

[Qemu-devel] [PATCH 0/7] Improve buffer_is_zero

2016-08-23 Thread Richard Henderson
Patches 1-3 remove the use of ifunc from the implementation. Patch 5 adjusts the x86 implementation a bit more to take advantage of ptest (in sse4.1) and unaligned accesses (in avx1). Patches 2 and 6 are the result of my conversation with Vijaya Kumar with respect to ThunderX. Patch 7 is the res