Re: [Qemu-devel] [PATCH 0/5] trace: Add events for vCPU memory accesses

2016-03-23 Thread Lluís Vilanova
Peter Maydell writes: > On 22 March 2016 at 19:23, Lluís Vilanova wrote: >> Peter Maydell writes: >>> Well, that's why I'm not certain about it. I would prefer us to >>> not trace the accesses rather than put a trace in a wrong >>> position. >> >> Theoretically, that's what DEBUG_REMAP is for. A

Re: [Qemu-devel] [PATCH 0/5] trace: Add events for vCPU memory accesses

2016-03-22 Thread Peter Maydell
On 22 March 2016 at 19:23, Lluís Vilanova wrote: > Peter Maydell writes: >> Well, that's why I'm not certain about it. I would prefer us to >> not trace the accesses rather than put a trace in a wrong >> position. > > Theoretically, that's what DEBUG_REMAP is for. A temporary host buffer is > allo

Re: [Qemu-devel] [PATCH 0/5] trace: Add events for vCPU memory accesses

2016-03-22 Thread Lluís Vilanova
Peter Maydell writes: > On 22 March 2016 at 14:02, Lluís Vilanova wrote: >> Stefan Hajnoczi writes: >> >>> On Wed, Mar 16, 2016 at 03:10:01PM +, Peter Maydell wrote: The first two patches which add TCG guest data access tracing look OK to me, but I'm much less sure about the last t

Re: [Qemu-devel] [PATCH 0/5] trace: Add events for vCPU memory accesses

2016-03-22 Thread Peter Maydell
On 22 March 2016 at 14:02, Lluís Vilanova wrote: > Stefan Hajnoczi writes: > >> On Wed, Mar 16, 2016 at 03:10:01PM +, Peter Maydell wrote: >>> The first two patches which add TCG guest data access tracing look >>> OK to me, but I'm much less sure about the last three which are >>> adding traci

Re: [Qemu-devel] [PATCH 0/5] trace: Add events for vCPU memory accesses

2016-03-22 Thread Lluís Vilanova
Stefan Hajnoczi writes: > On Wed, Mar 16, 2016 at 03:10:01PM +, Peter Maydell wrote: >> On 2 March 2016 at 10:55, Stefan Hajnoczi wrote: >> > On Tue, Feb 23, 2016 at 07:22:07PM +0100, Lluís Vilanova wrote: >> >> NOTE: This series applies on top of "trace: Show vCPU info in guest code >> >> e

Re: [Qemu-devel] [PATCH 0/5] trace: Add events for vCPU memory accesses

2016-03-22 Thread Stefan Hajnoczi
On Wed, Mar 16, 2016 at 03:10:01PM +, Peter Maydell wrote: > On 2 March 2016 at 10:55, Stefan Hajnoczi wrote: > > On Tue, Feb 23, 2016 at 07:22:07PM +0100, Lluís Vilanova wrote: > >> NOTE: This series applies on top of "trace: Show vCPU info in guest code > >> events" > >> > >> This series ad

Re: [Qemu-devel] [PATCH 0/5] trace: Add events for vCPU memory accesses

2016-03-19 Thread Peter Maydell
On 2 March 2016 at 10:55, Stefan Hajnoczi wrote: > On Tue, Feb 23, 2016 at 07:22:07PM +0100, Lluís Vilanova wrote: >> NOTE: This series applies on top of "trace: Show vCPU info in guest code >> events" >> >> This series adds to new events: >> >> * guest_vmem: memory accesses performed by vCPUs (g

Re: [Qemu-devel] [PATCH 0/5] trace: Add events for vCPU memory accesses

2016-03-02 Thread Stefan Hajnoczi
On Tue, Feb 23, 2016 at 07:22:07PM +0100, Lluís Vilanova wrote: > NOTE: This series applies on top of "trace: Show vCPU info in guest code > events" > > This series adds to new events: > > * guest_vmem: memory accesses performed by vCPUs (guest code) > > * guest_vmem_user_syscall: memory access

[Qemu-devel] [PATCH 0/5] trace: Add events for vCPU memory accesses

2016-02-23 Thread Lluís Vilanova
NOTE: This series applies on top of "trace: Show vCPU info in guest code events" This series adds to new events: * guest_vmem: memory accesses performed by vCPUs (guest code) * guest_vmem_user_syscall: memory accesses performed by syscall emulation when running QEMU in user-mode. Signed-off-b