Re: [Qemu-devel] [PATCH 0/5] atapi: Implement 'media' subcommand for GESN

2011-04-11 Thread Amit Shah
On (Mon) 11 Apr 2011 [15:46:33], Markus Armbruster wrote: > Amit Shah writes: > > > On (Fri) 08 Apr 2011 [11:39:26], Markus Armbruster wrote: > >> Results of quick test run now, patch review to follow. > >> > >> Test uses a simple program to try ioctl CDROM_DRIVE_STATUS (attached). > > > > ... >

Re: [Qemu-devel] [PATCH 0/5] atapi: Implement 'media' subcommand for GESN

2011-04-11 Thread Markus Armbruster
Amit Shah writes: > On (Fri) 08 Apr 2011 [11:39:26], Markus Armbruster wrote: >> Results of quick test run now, patch review to follow. >> >> Test uses a simple program to try ioctl CDROM_DRIVE_STATUS (attached). > > ... > >> Test in guest without your patches: >> >> [start with empty drive

Re: [Qemu-devel] [PATCH 0/5] atapi: Implement 'media' subcommand for GESN

2011-04-10 Thread Amit Shah
On (Fri) 08 Apr 2011 [11:39:26], Markus Armbruster wrote: > Results of quick test run now, patch review to follow. > > Test uses a simple program to try ioctl CDROM_DRIVE_STATUS (attached). ... > Test in guest without your patches: > > [start with empty drive] > # ./drive-status >

Re: [Qemu-devel] [PATCH 0/5] atapi: Implement 'media' subcommand for GESN

2011-04-08 Thread Markus Armbruster
Results of quick test run now, patch review to follow. Test uses a simple program to try ioctl CDROM_DRIVE_STATUS (attached). Test run in the host: [start with tray closed & empty] $ ./drive-status CDS_NO_DISC $ eject /dev/sr0 [tray opens] $ ./drive-status CDS_TRAY_

[Qemu-devel] [PATCH 0/5] atapi: Implement 'media' subcommand for GESN

2011-04-08 Thread Amit Shah
The GET_EVENT_STATUS_NOTIFICATION ATAPI command is listed as a mandatory command in the spec but we don't really implement it any of its sub-commands. The commit message for the last commit explains why implementing just the media subcommand is helpful and how it goes a long way in getting guests