Re: [Qemu-devel] [PATCH 0/5] Refactor common PCI IDE functions from CMD646

2019-01-23 Thread John Snow
On 1/10/19 7:36 PM, BALATON Zoltan wrote: > Hello, > > This series is a small refactoring that moves some common PCI IDE io > mem ops functions from the CMD646 model to the PCI IDE model so a > CMD646 specific type can be dropped from PCIIDEState, removes code > duplication from SiI3112 model (

Re: [Qemu-devel] [PATCH 0/5] Refactor common PCI IDE functions from CMD646

2019-01-22 Thread Richard Henderson
On 1/21/19 5:44 PM, John Snow wrote: >> BALATON Zoltan (5): >> cmd646: Remove unused variable >> cmd646: Remove IDEBus from CMD646BAR >> cmd646: Move PCI IDE specific functions to ide/pci.c >> ide: Get rid of CMD646BAR struct >> sii3112: Remove duplicated code and use PCI IDE ops instead

Re: [Qemu-devel] [PATCH 0/5] Refactor common PCI IDE functions from CMD646

2019-01-21 Thread John Snow
On 1/10/19 7:36 PM, BALATON Zoltan wrote: > Hello, > > This series is a small refactoring that moves some common PCI IDE io > mem ops functions from the CMD646 model to the PCI IDE model so a > CMD646 specific type can be dropped from PCIIDEState, removes code > duplication from SiI3112 model (

Re: [Qemu-devel] [PATCH 0/5] Refactor common PCI IDE functions from CMD646

2019-01-18 Thread Mark Cave-Ayland
On 11/01/2019 00:36, BALATON Zoltan wrote: > Hello, > > This series is a small refactoring that moves some common PCI IDE io > mem ops functions from the CMD646 model to the PCI IDE model so a > CMD646 specific type can be dropped from PCIIDEState, removes code > duplication from SiI3112 model (a

Re: [Qemu-devel] [PATCH 0/5] Refactor common PCI IDE functions from CMD646

2019-01-15 Thread John Snow
On 1/10/19 7:36 PM, BALATON Zoltan wrote: > Hello, > > This series is a small refactoring that moves some common PCI IDE io > mem ops functions from the CMD646 model to the PCI IDE model so a > CMD646 specific type can be dropped from PCIIDEState, removes code > duplication from SiI3112 model (

[Qemu-devel] [PATCH 0/5] Refactor common PCI IDE functions from CMD646

2019-01-10 Thread BALATON Zoltan
Hello, This series is a small refactoring that moves some common PCI IDE io mem ops functions from the CMD646 model to the PCI IDE model so a CMD646 specific type can be dropped from PCIIDEState, removes code duplication from SiI3112 model (also fixing a bug) and allows these functions to be used