Re: [Qemu-devel] [PATCH 0/4] cuda/mos6522 migration fixes

2018-06-07 Thread David Gibson
On Thu, Jun 07, 2018 at 06:17:47PM +0100, Mark Cave-Ayland wrote: > Whilst performing a random migration test for the Mac machines I noticed > a regression (patch 1) which prevented the loadvm from completing > successfully. A big thank you to Peter and David on IRC who pointed me > in the right di

Re: [Qemu-devel] [PATCH 0/4] cuda/mos6522 migration fixes

2018-06-07 Thread Philippe Mathieu-Daudé
On 06/07/2018 05:17 PM, Peter Maydell wrote: > On 7 June 2018 at 20:18, Philippe Mathieu-Daudé wrote: >> You forgot patch 5 "vmstate: Remove VMSTATE_TIMER_PTR_TEST" :) > > It's a generic macro that might have utility in future, > and it fits into a slot in the matrix of possible VMSTATE > macros,

Re: [Qemu-devel] [PATCH 0/4] cuda/mos6522 migration fixes

2018-06-07 Thread Peter Maydell
On 7 June 2018 at 20:18, Philippe Mathieu-Daudé wrote: > You forgot patch 5 "vmstate: Remove VMSTATE_TIMER_PTR_TEST" :) It's a generic macro that might have utility in future, and it fits into a slot in the matrix of possible VMSTATE macros, so I wouldn't bother. (It's kind of irritating that we

Re: [Qemu-devel] [PATCH 0/4] cuda/mos6522 migration fixes

2018-06-07 Thread Philippe Mathieu-Daudé
On 06/07/2018 02:17 PM, Mark Cave-Ayland wrote: > Whilst performing a random migration test for the Mac machines I noticed > a regression (patch 1) which prevented the loadvm from completing > successfully. A big thank you to Peter and David on IRC who pointed me > in the right direction in order t

[Qemu-devel] [PATCH 0/4] cuda/mos6522 migration fixes

2018-06-07 Thread Mark Cave-Ayland
Whilst performing a random migration test for the Mac machines I noticed a regression (patch 1) which prevented the loadvm from completing successfully. A big thank you to Peter and David on IRC who pointed me in the right direction in order to fix the bug. Once that was working I spent a bit more