Re: [Qemu-devel] [PATCH 0/4] block: add optional 'speed' parameter to block-stream

2012-04-23 Thread Luiz Capitulino
On Mon, 23 Apr 2012 14:44:27 -0600 Eric Blake wrote: > On 04/23/2012 01:38 PM, Anthony Liguori wrote: > >>> I like the approach of adding a new optional parameter; that is a > >>> workable solution for libvirt (that is, libvirt can assume that if the > >>> spelling 'block-stream' is available, th

Re: [Qemu-devel] [PATCH 0/4] block: add optional 'speed' parameter to block-stream

2012-04-23 Thread Eric Blake
On 04/23/2012 01:38 PM, Anthony Liguori wrote: >>> I like the approach of adding a new optional parameter; that is a >>> workable solution for libvirt (that is, libvirt can assume that if the >>> spelling 'block-stream' is available, then so is the optional 'speed' >>> parameter, if this patch is i

Re: [Qemu-devel] [PATCH 0/4] block: add optional 'speed' parameter to block-stream

2012-04-23 Thread Luiz Capitulino
On Mon, 23 Apr 2012 22:03:42 +0200 Paolo Bonzini wrote: > Il 23/04/2012 21:38, Luiz Capitulino ha scritto: > > On Mon, 23 Apr 2012 21:36:39 +0200 > > Paolo Bonzini wrote: > > > >> Il 23/04/2012 20:04, Luiz Capitulino ha scritto: > >>> The optional parameter is fine for me too, but we recently h

Re: [Qemu-devel] [PATCH 0/4] block: add optional 'speed' parameter to block-stream

2012-04-23 Thread Paolo Bonzini
Il 23/04/2012 21:38, Luiz Capitulino ha scritto: > On Mon, 23 Apr 2012 21:36:39 +0200 > Paolo Bonzini wrote: > >> Il 23/04/2012 20:04, Luiz Capitulino ha scritto: >>> The optional parameter is fine for me too, but we recently had a >>> discussion where it was decided that we should add new comman

Re: [Qemu-devel] [PATCH 0/4] block: add optional 'speed' parameter to block-stream

2012-04-23 Thread Anthony Liguori
On 04/23/2012 01:04 PM, Luiz Capitulino wrote: On Mon, 23 Apr 2012 11:33:27 -0600 Eric Blake wrote: On 04/23/2012 09:39 AM, Stefan Hajnoczi wrote: This series is based on Luiz' latest QMP pull request at git://repo.or.cz/qemu/qmp-unstable.git queue/qmp (d980956d5bfa9f4fd56c00a0b168c3c0f67bc0d

Re: [Qemu-devel] [PATCH 0/4] block: add optional 'speed' parameter to block-stream

2012-04-23 Thread Luiz Capitulino
On Mon, 23 Apr 2012 21:36:39 +0200 Paolo Bonzini wrote: > Il 23/04/2012 20:04, Luiz Capitulino ha scritto: > > The optional parameter is fine for me too, but we recently had a > > discussion where it was decided that we should add new commands instead > > of extending existing ones. > > > > Anth

Re: [Qemu-devel] [PATCH 0/4] block: add optional 'speed' parameter to block-stream

2012-04-23 Thread Paolo Bonzini
Il 23/04/2012 20:04, Luiz Capitulino ha scritto: > The optional parameter is fine for me too, but we recently had a > discussion where it was decided that we should add new commands instead > of extending existing ones. > > Anthony, I believe we're already taking that position, right? This comman

Re: [Qemu-devel] [PATCH 0/4] block: add optional 'speed' parameter to block-stream

2012-04-23 Thread Luiz Capitulino
On Mon, 23 Apr 2012 11:33:27 -0600 Eric Blake wrote: > On 04/23/2012 09:39 AM, Stefan Hajnoczi wrote: > > This series is based on Luiz' latest QMP pull request at > > git://repo.or.cz/qemu/qmp-unstable.git queue/qmp > > (d980956d5bfa9f4fd56c00a0b168c3c0f67bc0d2). This dependency is necessary > >

Re: [Qemu-devel] [PATCH 0/4] block: add optional 'speed' parameter to block-stream

2012-04-23 Thread Eric Blake
On 04/23/2012 09:39 AM, Stefan Hajnoczi wrote: > This series is based on Luiz' latest QMP pull request at > git://repo.or.cz/qemu/qmp-unstable.git queue/qmp > (d980956d5bfa9f4fd56c00a0b168c3c0f67bc0d2). This dependency is necessary > because this series conflicts with the block_stream -> block-str

[Qemu-devel] [PATCH 0/4] block: add optional 'speed' parameter to block-stream

2012-04-23 Thread Stefan Hajnoczi
This series is based on Luiz' latest QMP pull request at git://repo.or.cz/qemu/qmp-unstable.git queue/qmp (d980956d5bfa9f4fd56c00a0b168c3c0f67bc0d2). This dependency is necessary because this series conflicts with the block_stream -> block-stream rename. Eric Blake raised concerns about the inabi