Re: [Qemu-devel] [PATCH 0/3] usb-mtp: fix ObjectInfo request handling

2019-04-17 Thread Gerd Hoffmann
On Tue, Apr 16, 2019 at 11:27:06PM +0100, Peter Maydell wrote: > On Tue, 16 Apr 2019 at 20:33, Peter Maydell wrote: > > > > On Tue, 16 Apr 2019 at 18:27, Peter Maydell > > wrote: > > > Having thought a bit more I think I'd definitely like to apply > > > just patch 2 for 4.0. Could people try to

Re: [Qemu-devel] [PATCH 0/3] usb-mtp: fix ObjectInfo request handling

2019-04-16 Thread Peter Maydell
On Tue, 16 Apr 2019 at 20:33, Peter Maydell wrote: > > On Tue, 16 Apr 2019 at 18:27, Peter Maydell wrote: > > Having thought a bit more I think I'd definitely like to apply > > just patch 2 for 4.0. Could people try to test that and confirm > > that it at least does not make the feature behave an

Re: [Qemu-devel] [PATCH 0/3] usb-mtp: fix ObjectInfo request handling

2019-04-16 Thread Peter Maydell
On Tue, 16 Apr 2019 at 18:27, Peter Maydell wrote: > > On Tue, 16 Apr 2019 at 14:35, Peter Maydell wrote: > > > > On Mon, 15 Apr 2019 at 16:45, Daniel P. Berrangé > > wrote: > > > > > > Two previous attempts to fix this due to GCC 9 highlighting > > > unaligned data access. My attempt: > > > >

Re: [Qemu-devel] [PATCH 0/3] usb-mtp: fix ObjectInfo request handling

2019-04-16 Thread Peter Maydell
On Tue, 16 Apr 2019 at 14:35, Peter Maydell wrote: > > On Mon, 15 Apr 2019 at 16:45, Daniel P. Berrangé wrote: > > > > Two previous attempts to fix this due to GCC 9 highlighting > > unaligned data access. My attempt: > > > > https://lists.gnu.org/archive/html/qemu-devel/2019-03/msg07763.html >

Re: [Qemu-devel] [PATCH 0/3] usb-mtp: fix ObjectInfo request handling

2019-04-16 Thread Bandan Das
Daniel P. Berrangé writes: >> I can't find usb-mtp sending a "I/O error" on an error condition >> for the objectinfo phase. It might be libmtp or even the command itself >> failing for some reason. For incomplete transfer, I just checked, it's >> spitting out the error message correctly as INCOMP

Re: [Qemu-devel] [PATCH 0/3] usb-mtp: fix ObjectInfo request handling

2019-04-16 Thread Daniel P . Berrangé
On Tue, Apr 16, 2019 at 12:45:04PM -0400, Bandan Das wrote: > Daniel P. Berrangé writes: > > > On Tue, Apr 16, 2019 at 12:10:16PM -0400, Bandan Das wrote: > >> Daniel P. Berrangé writes: > >> ... > >> >> > The store is read only by default. Are you trying something like: > >> >> > -device usb-m

Re: [Qemu-devel] [PATCH 0/3] usb-mtp: fix ObjectInfo request handling

2019-04-16 Thread Bandan Das
Daniel P. Berrangé writes: > On Tue, Apr 16, 2019 at 12:10:16PM -0400, Bandan Das wrote: >> Daniel P. Berrangé writes: >> ... >> >> > The store is read only by default. Are you trying something like: >> >> > -device usb-mtp,rootdir=/code/mtpshare,readonly=false ? >> >> >> >> Ah ha, I didn't re

Re: [Qemu-devel] [PATCH 0/3] usb-mtp: fix ObjectInfo request handling

2019-04-16 Thread Daniel P . Berrangé
On Tue, Apr 16, 2019 at 12:10:16PM -0400, Bandan Das wrote: > Daniel P. Berrangé writes: > ... > >> > The store is read only by default. Are you trying something like: > >> > -device usb-mtp,rootdir=/code/mtpshare,readonly=false ? > >> > >> Ah ha, I didn't realize I had to enable write support e

Re: [Qemu-devel] [PATCH 0/3] usb-mtp: fix ObjectInfo request handling

2019-04-16 Thread Bandan Das
Daniel P. Berrangé writes: ... >> > The store is read only by default. Are you trying something like: >> > -device usb-mtp,rootdir=/code/mtpshare,readonly=false ? >> >> Ah ha, I didn't realize I had to enable write support explicitly. Will >> retry with that. > > Even after setting readonly=fal

Re: [Qemu-devel] [PATCH 0/3] usb-mtp: fix ObjectInfo request handling

2019-04-16 Thread Peter Maydell
On Mon, 15 Apr 2019 at 16:45, Daniel P. Berrangé wrote: > > Two previous attempts to fix this due to GCC 9 highlighting > unaligned data access. My attempt: > > https://lists.gnu.org/archive/html/qemu-devel/2019-03/msg07763.html > > And a previous one: > > https://lists.gnu.org/archive/html/qe

Re: [Qemu-devel] [PATCH 0/3] usb-mtp: fix ObjectInfo request handling

2019-04-16 Thread Daniel P . Berrangé
On Mon, Apr 15, 2019 at 05:54:26PM +0100, Daniel P. Berrangé wrote: > On Mon, Apr 15, 2019 at 12:52:41PM -0400, Bandan Das wrote: > > Daniel P. Berrangé writes: > > > > > Two previous attempts to fix this due to GCC 9 highlighting > > > unaligned data access. My attempt: > > > > > > https://lis

Re: [Qemu-devel] [PATCH 0/3] usb-mtp: fix ObjectInfo request handling

2019-04-15 Thread Daniel P . Berrangé
On Mon, Apr 15, 2019 at 12:52:41PM -0400, Bandan Das wrote: > Daniel P. Berrangé writes: > > > Two previous attempts to fix this due to GCC 9 highlighting > > unaligned data access. My attempt: > > > > https://lists.gnu.org/archive/html/qemu-devel/2019-03/msg07763.html > > > > And a previous on

Re: [Qemu-devel] [PATCH 0/3] usb-mtp: fix ObjectInfo request handling

2019-04-15 Thread Bandan Das
Daniel P. Berrangé writes: > Two previous attempts to fix this due to GCC 9 highlighting > unaligned data access. My attempt: > > https://lists.gnu.org/archive/html/qemu-devel/2019-03/msg07763.html > > And a previous one: > > https://lists.gnu.org/archive/html/qemu-devel/2019-02/msg07923.html

[Qemu-devel] [PATCH 0/3] usb-mtp: fix ObjectInfo request handling

2019-04-15 Thread Daniel P . Berrangé
Two previous attempts to fix this due to GCC 9 highlighting unaligned data access. My attempt: https://lists.gnu.org/archive/html/qemu-devel/2019-03/msg07763.html And a previous one: https://lists.gnu.org/archive/html/qemu-devel/2019-02/msg07923.html https://lists.gnu.org/archive/html/qemu