Re: [Qemu-devel] [PATCH 0/3] scripts: add argparse module for Python 2.6 compatibility

2017-08-30 Thread Stefan Hajnoczi
On Fri, Aug 25, 2017 at 04:57:29PM +0100, Stefan Hajnoczi wrote: > Many scripts can benefit from the standard library argparse module, which has > improvements over the older optparse module. Unfortunately argparse was only > shipped in Python 2.7 so we need a fallback for Python 2.6. > > This pa

Re: [Qemu-devel] [PATCH 0/3] scripts: add argparse module for Python 2.6 compatibility

2017-08-29 Thread Philippe Mathieu-Daudé
On 08/29/2017 07:01 AM, Stefan Hajnoczi wrote: On Fri, Aug 25, 2017 at 12:42:44PM -0500, Eric Blake wrote: On 08/25/2017 11:40 AM, Peter Maydell wrote: Our choices about our dependencies are generally driven by "what are the versions available on the oldest distros which we wish to support buil

Re: [Qemu-devel] [PATCH 0/3] scripts: add argparse module for Python 2.6 compatibility

2017-08-29 Thread Stefan Hajnoczi
On Fri, Aug 25, 2017 at 12:42:44PM -0500, Eric Blake wrote: > On 08/25/2017 11:40 AM, Peter Maydell wrote: > > Our choices about our dependencies are generally driven by "what > > are the versions available on the oldest distros which we wish > > to support building QEMU on", which typically is wha

Re: [Qemu-devel] [PATCH 0/3] scripts: add argparse module for Python 2.6 compatibility

2017-08-29 Thread Stefan Hajnoczi
On Fri, Aug 25, 2017 at 09:24:36AM -0700, no-re...@patchew.org wrote: > === OUTPUT BEGIN === > Checking PATCH 1/3: scripts: add argparse module for Python 2.6 > compatibility... > ERROR: trailing whitespace > #115: FILE: COPYING.PYTHON:93: > +Reserved" are retained in Python alone or in any deriva

Re: [Qemu-devel] [PATCH 0/3] scripts: add argparse module for Python 2.6 compatibility

2017-08-28 Thread John Snow
On 08/25/2017 11:57 AM, Stefan Hajnoczi wrote: > Many scripts can benefit from the standard library argparse module, which has > improvements over the older optparse module. Unfortunately argparse was only > shipped in Python 2.7 so we need a fallback for Python 2.6. > > This patch series adds

Re: [Qemu-devel] [PATCH 0/3] scripts: add argparse module for Python 2.6 compatibility

2017-08-25 Thread Eric Blake
On 08/25/2017 11:40 AM, Peter Maydell wrote: > Our choices about our dependencies are generally driven by "what > are the versions available on the oldest distros which we wish > to support building QEMU on", which typically is whatever the > long-term-support versions of Ubuntu, SUSE, Redhat, etc

Re: [Qemu-devel] [PATCH 0/3] scripts: add argparse module for Python 2.6 compatibility

2017-08-25 Thread Peter Maydell
On 25 August 2017 at 17:35, Philippe Mathieu-Daudé wrote: > Hi Stefan, > > On 08/25/2017 12:57 PM, Stefan Hajnoczi wrote: >> >> Many scripts can benefit from the standard library argparse module, which >> has >> improvements over the older optparse module. Unfortunately argparse was >> only >> sh

Re: [Qemu-devel] [PATCH 0/3] scripts: add argparse module for Python 2.6 compatibility

2017-08-25 Thread Philippe Mathieu-Daudé
Hi Stefan, On 08/25/2017 12:57 PM, Stefan Hajnoczi wrote: Many scripts can benefit from the standard library argparse module, which has improvements over the older optparse module. Unfortunately argparse was only shipped in Python 2.7 so we need a fallback for Python 2.6. I probably missed so

Re: [Qemu-devel] [PATCH 0/3] scripts: add argparse module for Python 2.6 compatibility

2017-08-25 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20170825155732.15665-1-stefa...@redhat.com Subject: [Qemu-devel] [PATCH 0/3] scripts: add argparse module for Python 2.6 compatibility === TEST SCRIPT BEGIN === #!/bin/bash

[Qemu-devel] [PATCH 0/3] scripts: add argparse module for Python 2.6 compatibility

2017-08-25 Thread Stefan Hajnoczi
Many scripts can benefit from the standard library argparse module, which has improvements over the older optparse module. Unfortunately argparse was only shipped in Python 2.7 so we need a fallback for Python 2.6. This patch series adds a copy of argparse.py and updates scripts as necessary to i