Re: [Qemu-devel] [PATCH 0/3] scripts/qemu-gdb: Add event tracing support

2015-05-18 Thread Stefan Hajnoczi
On Thu, May 14, 2015 at 05:43:52PM +0100, Peter Maydell wrote: > This patchset adds support for two new commands to our > gdb scripts, which allow dynamically enabling and disabling > tracing of events, like this: > > (gdb) source scripts/qemu-gdb.py > (gdb) qemu trace-enable translate_block > En

Re: [Qemu-devel] [PATCH 0/3] scripts/qemu-gdb: Add event tracing support

2015-05-18 Thread Stefan Hajnoczi
On Thu, May 14, 2015 at 05:43:52PM +0100, Peter Maydell wrote: > This patchset adds support for two new commands to our > gdb scripts, which allow dynamically enabling and disabling > tracing of events, like this: > > (gdb) source scripts/qemu-gdb.py > (gdb) qemu trace-enable translate_block > En

Re: [Qemu-devel] [PATCH 0/3] scripts/qemu-gdb: Add event tracing support

2015-05-15 Thread Markus Armbruster
Jan Kiszka writes: > On 2015-05-15 15:21, Markus Armbruster wrote: >> Jan Kiszka writes: >> >>> On 2015-05-15 14:18, Markus Armbruster wrote: Peter Maydell writes: > On 15 May 2015 at 08:58, Markus Armbruster wrote: >> Since you're touching qemu-gdb.py anyway, could you stic

Re: [Qemu-devel] [PATCH 0/3] scripts/qemu-gdb: Add event tracing support

2015-05-15 Thread Jan Kiszka
On 2015-05-15 15:21, Markus Armbruster wrote: > Jan Kiszka writes: > >> On 2015-05-15 14:18, Markus Armbruster wrote: >>> Peter Maydell writes: >>> On 15 May 2015 at 08:58, Markus Armbruster wrote: > Since you're touching qemu-gdb.py anyway, could you stick in a brief > comment exp

Re: [Qemu-devel] [PATCH 0/3] scripts/qemu-gdb: Add event tracing support

2015-05-15 Thread Markus Armbruster
Jan Kiszka writes: > On 2015-05-15 14:18, Markus Armbruster wrote: >> Peter Maydell writes: >> >>> On 15 May 2015 at 08:58, Markus Armbruster wrote: Since you're touching qemu-gdb.py anyway, could you stick in a brief comment explaining how to put it to use? >>> >>> Good idea. It tur

Re: [Qemu-devel] [PATCH 0/3] scripts/qemu-gdb: Add event tracing support

2015-05-15 Thread Jan Kiszka
On 2015-05-15 14:18, Markus Armbruster wrote: > Peter Maydell writes: > >> On 15 May 2015 at 08:58, Markus Armbruster wrote: >>> Since you're touching qemu-gdb.py anyway, could you stick in a brief >>> comment explaining how to put it to use? >> >> Good idea. It turns out the answer is just "sou

Re: [Qemu-devel] [PATCH 0/3] scripts/qemu-gdb: Add event tracing support

2015-05-15 Thread Markus Armbruster
Peter Maydell writes: > On 15 May 2015 at 08:58, Markus Armbruster wrote: >> Since you're touching qemu-gdb.py anyway, could you stick in a brief >> comment explaining how to put it to use? > > Good idea. It turns out the answer is just "source it from gdb", > but it took me a little while to fi

Re: [Qemu-devel] [PATCH 0/3] scripts/qemu-gdb: Add event tracing support

2015-05-15 Thread Peter Maydell
On 15 May 2015 at 08:58, Markus Armbruster wrote: > Since you're touching qemu-gdb.py anyway, could you stick in a brief > comment explaining how to put it to use? Good idea. It turns out the answer is just "source it from gdb", but it took me a little while to find that out, so worth commenting.

Re: [Qemu-devel] [PATCH 0/3] scripts/qemu-gdb: Add event tracing support

2015-05-15 Thread Markus Armbruster
Since you're touching qemu-gdb.py anyway, could you stick in a brief comment explaining how to put it to use?

[Qemu-devel] [PATCH 0/3] scripts/qemu-gdb: Add event tracing support

2015-05-14 Thread Peter Maydell
This patchset adds support for two new commands to our gdb scripts, which allow dynamically enabling and disabling tracing of events, like this: (gdb) source scripts/qemu-gdb.py (gdb) qemu trace-enable translate_block Enabled trace event translate_block Breakpoint 1 at 0xb634f: file ../trace/gene