Re: [Qemu-devel] [PATCH 0/3] qerror: proper errors for qmp_block_resize()

2012-01-04 Thread Stefan Hajnoczi
On Wed, Jan 4, 2012 at 8:01 PM, Luiz Capitulino wrote: > On Wed,  4 Jan 2012 17:38:20 + > Stefan Hajnoczi wrote: > >> The block resize command returns undefined errors if things go wrong.  This >> is >> bad since users will have no chance to understand what failed. > > Oops, this introduces

Re: [Qemu-devel] [PATCH 0/3] qerror: proper errors for qmp_block_resize()

2012-01-04 Thread Luiz Capitulino
On Wed, 4 Jan 2012 17:38:20 + Stefan Hajnoczi wrote: > The block resize command returns undefined errors if things go wrong. This is > bad since users will have no chance to understand what failed. Oops, this introduces a segfault try "block_resize ide1-cd0 100" in the monitor and you'll s

[Qemu-devel] [PATCH 0/3] qerror: proper errors for qmp_block_resize()

2012-01-04 Thread Stefan Hajnoczi
The block resize command returns undefined errors if things go wrong. This is bad since users will have no chance to understand what failed. Patch 3 makes qmp_block_resize() use meaningful errors. We introduce new qerrors for ENOMEDIUM and EACCES since nothing exists yet. When doing this I noti