Re: [Qemu-devel] [PATCH 0/3] net: reimplement -net nic diagnostic fix

2011-06-22 Thread Anthony Liguori
On 05/20/2011 10:49 AM, Peter Maydell wrote: This patchset reverts commit f68b9d672, which was triggering spuriously for NICs created via -device rather than -net nic. It then reimplements the improved diagnostics with a different approach which only applies to '-net nic'. (It's only -net nic dev

Re: [Qemu-devel] [PATCH 0/3] net: reimplement -net nic diagnostic fix

2011-06-22 Thread Peter Maydell
Ping^2 ? On 5 June 2011 14:12, Peter Maydell wrote: > Combination 'ping' and 'oops I forgot to cc the net/ maintainers'... > > -- PMM > > On 20 May 2011 16:49, Peter Maydell wrote: >> This patchset reverts commit f68b9d672, which was triggering >> spuriously for NICs created via -device rather t

Re: [Qemu-devel] [PATCH 0/3] net: reimplement -net nic diagnostic fix

2011-06-05 Thread Peter Maydell
Combination 'ping' and 'oops I forgot to cc the net/ maintainers'... -- PMM On 20 May 2011 16:49, Peter Maydell wrote: > This patchset reverts commit f68b9d672, which was triggering > spuriously for NICs created via -device rather than -net nic. > It then reimplements the improved diagnostics wi

Re: [Qemu-devel] [PATCH 0/3] net: reimplement -net nic diagnostic fix

2011-05-23 Thread Markus Armbruster
Peter Maydell writes: > This patchset reverts commit f68b9d672, which was triggering > spuriously for NICs created via -device rather than -net nic. > It then reimplements the improved diagnostics with a different > approach which only applies to '-net nic'. (It's only -net nic > devices that can

Re: [Qemu-devel] [PATCH 0/3] net: reimplement -net nic diagnostic fix

2011-05-20 Thread Jan Kiszka
On 2011-05-20 18:12, Peter Maydell wrote: > On 20 May 2011 17:07, Jan Kiszka wrote: >> On 2011-05-20 18:04, Peter Maydell wrote: >>> I think that avoiding MAC address clashes should be done by >>> having net_init_nic() call qemu_macaddr_default_if_unset() >> >> You mean qemu_new_nic? Otherwise it

Re: [Qemu-devel] [PATCH 0/3] net: reimplement -net nic diagnostic fix

2011-05-20 Thread Peter Maydell
On 20 May 2011 17:07, Jan Kiszka wrote: > On 2011-05-20 18:04, Peter Maydell wrote: >> I think that avoiding MAC address clashes should be done by >> having net_init_nic() call qemu_macaddr_default_if_unset() > > You mean qemu_new_nic? Otherwise it wouldn't help. Will have a look to > move that ov

Re: [Qemu-devel] [PATCH 0/3] net: reimplement -net nic diagnostic fix

2011-05-20 Thread Jan Kiszka
On 2011-05-20 18:04, Peter Maydell wrote: > On 20 May 2011 16:55, Jan Kiszka wrote: >> On 2011-05-20 17:49, Peter Maydell wrote: >>> This patchset reverts commit f68b9d672, which was triggering >>> spuriously for NICs created via -device rather than -net nic. >>> It then reimplements the improved

Re: [Qemu-devel] [PATCH 0/3] net: reimplement -net nic diagnostic fix

2011-05-20 Thread Peter Maydell
On 20 May 2011 16:55, Jan Kiszka wrote: > On 2011-05-20 17:49, Peter Maydell wrote: >> This patchset reverts commit f68b9d672, which was triggering >> spuriously for NICs created via -device rather than -net nic. >> It then reimplements the improved diagnostics with a different >> approach which o

Re: [Qemu-devel] [PATCH 0/3] net: reimplement -net nic diagnostic fix

2011-05-20 Thread Jan Kiszka
On 2011-05-20 17:49, Peter Maydell wrote: > This patchset reverts commit f68b9d672, which was triggering > spuriously for NICs created via -device rather than -net nic. > It then reimplements the improved diagnostics with a different > approach which only applies to '-net nic'. (It's only -net nic

[Qemu-devel] [PATCH 0/3] net: reimplement -net nic diagnostic fix

2011-05-20 Thread Peter Maydell
This patchset reverts commit f68b9d672, which was triggering spuriously for NICs created via -device rather than -net nic. It then reimplements the improved diagnostics with a different approach which only applies to '-net nic'. (It's only -net nic devices that can be ignored (ie not instantiated);