Re: [Qemu-devel] [PATCH 0/3] mips setcond and movcond

2009-12-19 Thread Aurelien Jarno
On Sat, Dec 19, 2009 at 10:43:31PM +, Richard Henderson wrote: > It has been compile tested, but nothing else. > > I'm moderately surprised at the implementation of brcond. It's > missing the BLTZ, BLEZ, BGTZ, BGEZ branches. It's could be > improved with the SLTI and SLTIU insns used here w

[Qemu-devel] [PATCH 0/3] mips setcond and movcond

2009-12-19 Thread Richard Henderson
It has been compile tested, but nothing else. I'm moderately surprised at the implementation of brcond. It's missing the BLTZ, BLEZ, BGTZ, BGEZ branches. It's could be improved with the SLTI and SLTIU insns used here with setcond. Indeed, I suspect that a good implementation of brcond would be