Re: [Qemu-devel] [PATCH 0/3] client_migrate_switch and auto_switch (RHBZ 725009)

2011-08-26 Thread Daniel P. Berrange
On Fri, Aug 26, 2011 at 02:39:59PM +0200, Gerd Hoffmann wrote: > >> (1) libvirt sets spice ticket at dst (stage 2) > >> (2) migration src->dst (stage 3) > >> (3) spice client switches connection to dst > > > >This is actually what we have already. The problem is that > >the 'migration src->ds

Re: [Qemu-devel] [PATCH 0/3] client_migrate_switch and auto_switch (RHBZ 725009)

2011-08-26 Thread Gerd Hoffmann
(1) libvirt sets spice ticket at dst (stage 2) (2) migration src->dst (stage 3) (3) spice client switches connection to dst This is actually what we have already. The problem is that the 'migration src->dst' here can take an arbitrary amount of time. So by the time the spice client swit

Re: [Qemu-devel] [PATCH 0/3] client_migrate_switch and auto_switch (RHBZ 725009)

2011-08-26 Thread Daniel P. Berrange
On Fri, Aug 26, 2011 at 01:00:29PM +0200, Gerd Hoffmann wrote: > Hi, > > >>Ok, so I think we should be able to fix the race outlined above > >>without adding new monitor commands, just by letting libvirt set the > >>spice ticket in stage 2. > > > >Is that different then what I suggested in my re

Re: [Qemu-devel] [PATCH 0/3] client_migrate_switch and auto_switch (RHBZ 725009)

2011-08-26 Thread Gerd Hoffmann
Hi, Ok, so I think we should be able to fix the race outlined above without adding new monitor commands, just by letting libvirt set the spice ticket in stage 2. Is that different then what I suggested in my reply to Daniel's 5 stage outline? I think we have to care to not mix up switch-ho

Re: [Qemu-devel] [PATCH 0/3] client_migrate_switch and auto_switch (RHBZ 725009)

2011-08-26 Thread Alon Levy
On Fri, Aug 26, 2011 at 12:17:58PM +0200, Gerd Hoffmann wrote: > On 08/26/11 12:03, Daniel P. Berrange wrote: > >On Fri, Aug 26, 2011 at 11:54:49AM +0200, Gerd Hoffmann wrote: > >>On 08/19/11 19:08, Alon Levy wrote: > >>>Fix the ticket expiration on target vm for a spice connection without > >>>in

Re: [Qemu-devel] [PATCH 0/3] client_migrate_switch and auto_switch (RHBZ 725009)

2011-08-26 Thread Alon Levy
On Fri, Aug 26, 2011 at 11:03:38AM +0100, Daniel P. Berrange wrote: > On Fri, Aug 26, 2011 at 11:54:49AM +0200, Gerd Hoffmann wrote: > > On 08/19/11 19:08, Alon Levy wrote: > > >Fix the ticket expiration on target vm for a spice connection without > > >introducing > > >a race between the spice ser

Re: [Qemu-devel] [PATCH 0/3] client_migrate_switch and auto_switch (RHBZ 725009)

2011-08-26 Thread Gerd Hoffmann
On 08/26/11 12:03, Daniel P. Berrange wrote: On Fri, Aug 26, 2011 at 11:54:49AM +0200, Gerd Hoffmann wrote: On 08/19/11 19:08, Alon Levy wrote: Fix the ticket expiration on target vm for a spice connection without introducing a race between the spice server switching the client to the new host

Re: [Qemu-devel] [PATCH 0/3] client_migrate_switch and auto_switch (RHBZ 725009)

2011-08-26 Thread Daniel P. Berrange
On Fri, Aug 26, 2011 at 11:54:49AM +0200, Gerd Hoffmann wrote: > On 08/19/11 19:08, Alon Levy wrote: > >Fix the ticket expiration on target vm for a spice connection without > >introducing > >a race between the spice server switching the client to the new host itself > >and > >the target libvirt

Re: [Qemu-devel] [PATCH 0/3] client_migrate_switch and auto_switch (RHBZ 725009)

2011-08-26 Thread Gerd Hoffmann
On 08/19/11 19:08, Alon Levy wrote: Fix the ticket expiration on target vm for a spice connection without introducing a race between the spice server switching the client to the new host itself and the target libvirt setting the new expiration date, by adding an option to client_migrate_info to

[Qemu-devel] [PATCH 0/3] client_migrate_switch and auto_switch (RHBZ 725009)

2011-08-19 Thread Alon Levy
Fix the ticket expiration on target vm for a spice connection without introducing a race between the spice server switching the client to the new host itself and the target libvirt setting the new expiration date, by adding an option to client_migrate_info to not automatically switch the client on