Re: [Qemu-devel] [PATCH 0/3] Fix broken if statements

2010-08-02 Thread Joel Schopp
> Is there some magic (= tool) which detected these "broken windows" > in hw/loader.c, qemu-io.c and vl.c, or was it just a manual code > review or luck? I used a proprietary static analysis tool called BEAM. http://domino.research.ibm.com/comm/research.nsf/pages/r.da.beam.html It found pages o

Re: [Qemu-devel] [PATCH 0/3] Fix broken if statements

2010-08-01 Thread Stefan Weil
Am 01.08.2010 19:25, schrieb Andreas Färber: Am 22.07.2010 um 18:18 schrieb Stefan Weil: Am 21.07.2010 22:05, schrieb Joel Schopp: I have decided to apply the broken window theory of crime http://en.wikipedia.org/wiki/Broken_windows_theory to code, and more specifically to qemu[:] I'm hopin

Re: [Qemu-devel] [PATCH 0/3] Fix broken if statements

2010-08-01 Thread Andreas Färber
Am 22.07.2010 um 18:18 schrieb Stefan Weil: Am 21.07.2010 22:05, schrieb Joel Schopp: I have decided to apply the broken window theory of crime http://en.wikipedia.org/wiki/Broken_windows_theory to code, and more specifically to qemu[:] I'm hoping that fixing seemingly trivial bugs will actu

Re: [Qemu-devel] [PATCH 0/3] Fix broken if statements

2010-07-30 Thread Aurelien Jarno
On Wed, Jul 21, 2010 at 03:05:14PM -0500, Joel Schopp wrote: > I have decided to apply the broken window theory of crime > http://en.wikipedia.org/wiki/Broken_windows_theory to code, and > more specifically to qemu. I'm hoping that fixing seemingly trivial > bugs will actually fix some more serio

Re: [Qemu-devel] [PATCH 0/3] Fix broken if statements

2010-07-22 Thread Stefan Weil
Am 21.07.2010 22:05, schrieb Joel Schopp: I have decided to apply the broken window theory of crime http://en.wikipedia.org/wiki/Broken_windows_theory to code, and more specifically to qemu. I'm hoping that fixing seemingly trivial bugs will actually fix some more serious bugs, make the code run

[Qemu-devel] [PATCH 0/3] Fix broken if statements

2010-07-21 Thread Joel Schopp
I have decided to apply the broken window theory of crime http://en.wikipedia.org/wiki/Broken_windows_theory to code, and more specifically to qemu. I'm hoping that fixing seemingly trivial bugs will actually fix some more serious bugs, make the code run just a bit smoother, or at the very least