Re: [Qemu-devel] [PATCH 0/2 v2] introduce visitor for parsing suffixed integer

2012-12-26 Thread Eduardo Habkost
On Sun, Dec 23, 2012 at 02:34:21PM -0600, Anthony Liguori wrote: > Igor Mammedov writes: > > > v2: > > * Naming changes: > > - s/visit_type_uint_suffixed_int/visit_type_suffixed_int/ > > - use 'suffix_factor' instead of 'unit' > > * Added documentation to visit_type_suffixed_int() > >

Re: [Qemu-devel] [PATCH 0/2 v2] introduce visitor for parsing suffixed integer

2012-12-24 Thread Igor Mammedov
On Sun, 23 Dec 2012 14:34:21 -0600 Anthony Liguori wrote: > Igor Mammedov writes: > > > v2: > > * Naming changes: > > - s/visit_type_uint_suffixed_int/visit_type_suffixed_int/ > > - use 'suffix_factor' instead of 'unit' > > * Added documentation to visit_type_suffixed_int() > > * Fi

Re: [Qemu-devel] [PATCH 0/2 v2] introduce visitor for parsing suffixed integer

2012-12-23 Thread Anthony Liguori
Igor Mammedov writes: > v2: > * Naming changes: > - s/visit_type_uint_suffixed_int/visit_type_suffixed_int/ > - use 'suffix_factor' instead of 'unit' > * Added documentation to visit_type_suffixed_int() > * Fixed errp check. > * Style fixes This is not how visitors are supposed to b

[Qemu-devel] [PATCH 0/2 v2] introduce visitor for parsing suffixed integer

2012-12-10 Thread Igor Mammedov
v2: * Naming changes: - s/visit_type_uint_suffixed_int/visit_type_suffixed_int/ - use 'suffix_factor' instead of 'unit' * Added documentation to visit_type_suffixed_int() * Fixed errp check. * Style fixes Reference to previous version dicussion: http://lists.gnu.org/archive/html/q