Re: [Qemu-devel] [PATCH 0/2 v2] Break down the MTP write operation

2019-01-14 Thread Philippe Mathieu-Daudé
On 1/11/19 11:44 AM, Gerd Hoffmann wrote: > On Fri, Jan 11, 2019 at 03:20:41AM -0500, Bandan Das wrote: >> v2: >> Rebased on top of master and retested > > Thanks. Added to usb queue. Hi Gerd, did you update MTP_WRITE_BUF_SZ as suggested by Eric? +#include "qemu/units.h" ... -#define MTP_WR

Re: [Qemu-devel] [PATCH 0/2 v2] Break down the MTP write operation

2019-01-11 Thread Gerd Hoffmann
On Fri, Jan 11, 2019 at 03:20:41AM -0500, Bandan Das wrote: > v2: > Rebased on top of master and retested Thanks. Added to usb queue. cheers, Gerd

[Qemu-devel] [PATCH 0/2 v2] Break down the MTP write operation

2019-01-11 Thread Bandan Das
v2: Rebased on top of master and retested For larger files, not only do we keep reallocating to increase the mtp buffer size, the write also happens in one go. This does two things: Write to file upto a certain data size we have received so far and second, reuse the buffer again instead of real